Closed Bug 1300816 Opened 4 years ago Closed 4 years ago

Remove nsTimeout::mPrincipal

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: ehsan, Unassigned)

Details

Attachments

(1 file)

This seems to not be used for anything any more.
This seems to not be used for anything any more.
Attachment #8788549 - Flags: review?(bzbarsky)
Comment on attachment 8788549 [details] [diff] [review]
Remove nsTimeout::mPrincipal

r=me.

This used to be used for string setTimeout stuff.  But we started just using the principal of the window itself in bug 824864, which makes sense.  Given that we don't allow cross-origin setTimeout calls, this seems fine.  The interaction with document.domain is subtly different, but I don't think anyone cares.
Attachment #8788549 - Flags: review?(bzbarsky) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f7f3b88d969
Remove nsTimeout::mPrincipal; r=bzbarsky
https://hg.mozilla.org/mozilla-central/rev/9f7f3b88d969
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.