1300820 - Always use 'old' debugger frontend in Browser Toolbox

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P1)

Description

[Brian Grinstead [:bgrins]]

At least as of a build today, the new frontend breaks upon loading in BT.  On top of this, it's hard to manually flip prefs in BT profile (can't easily load about:config) so we can't give people a quick workaround to load the old forntend in case something breaks.

I suggest we flip the 'devtools.debugger.new-debugger-frontend' pref to false here: https://dxr.mozilla.org/mozilla-central/source/devtools/client/framework/toolbox-process-window.js#65

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: bt-error-message.png

Just for reference, here's a screenshot of the error I saw at startup: ReferenceError: promise is not defined panel.js:17:7

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: Bug 1300820 - Always use the current debugger frontend in Browser Toolbox;

Review commit: https://reviewboard.mozilla.org/r/77016/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77016/

Comment 3

[James Long (:jlongster)]

Comment on attachment 8788577 [details]
Bug 1300820 - Always use the current debugger frontend in Browser Toolbox;

https://reviewboard.mozilla.org/r/77016/#review75230

Awesome!

Comment 4

[James Long (:jlongster)]

Comment on attachment 8788577 [details]
Bug 1300820 - Always use the current debugger frontend in Browser Toolbox;

https://reviewboard.mozilla.org/r/77016/#review75232

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17f792799636
Always use the current debugger frontend in Browser Toolbox;r=jlongster

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/17f792799636