Closed Bug 1300830 Opened 3 years ago Closed 3 years ago

Remove XPCJSRuntime::mDetachedWrappedNativeProtoMap

Categories

(Core :: XPConnect, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

Bill noticed that nothing is ever added to this map, so it can be removed. It would be nice if this waited until bug 1288909 lands to avoid bitrotting it.
Assignee: nobody → continuation
It looks like there was a single place that added to this hash table when it was added back in 2001, and that was removed in bug 1032317 in 2014:
  https://hg.mozilla.org/mozilla-central/rev/edcbee0050bc
It was added in bug 87389.
Comment on attachment 8789002 [details]
Bug 1300830 - Remove XPCJSRuntime::mDetachedWrappedNativeProtoMap.

https://reviewboard.mozilla.org/r/77294/#review75630
Attachment #8789002 - Flags: review?(mrbkap) → review+
I was waiting for some other patch of mine to land first, but I'll just rebase and land it right now.
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b7fb3e4d917
Remove XPCJSRuntime::mDetachedWrappedNativeProtoMap. r=mrbkap
https://hg.mozilla.org/mozilla-central/rev/5b7fb3e4d917
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.