should we get rid of "NEW_FONT_HEIGHT_APIS"

RESOLVED FIXED

Status

()

Core
Internationalization
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: Shanjian Li, Assigned: Shanjian Li)

Tracking

({intl})

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
Font manipulation is platform specific issue. When we make any changes in API,
we use ifdef to allow some platform to implement the change before other platforms. 
"NEW_FONT_HEIGHT_APIS" is one such example. Now it is defined (thus implemented)
for XP_UNIX, XP_PC, XP_MAC, XP_BEOS. Is there any other platform missing? 
If not, it should be the right time to eliminate this flag and make it default? 

Since I didn't  see OS2, I will like to ask mkaply to verify this on OS/2.

mkaply, once this is done for OS2, please reassign it back to me.

Comment 1

16 years ago
XP_PC covers OS/2 and Windows
Assignee: mkaply → shanjian

Comment 2

16 years ago
Not OS/2 now.
OS: OS/2 → All
Hardware: PC → All

Comment 3

16 years ago
Yokoyama-san, could you please check this bug? feel free to reassign it back to 
IQA in case you need IQA's help.
Keywords: intl
QA Contact: ruixu → yokoyama
(Assignee)

Comment 4

16 years ago
jim, do you know if there is any platform that are not covered by XP_UNIX,
XP_PC, XP_MAC, XP_BEOS? 

Status: NEW → ASSIGNED

Comment 5

16 years ago
No I think you have them all.
(Assignee)

Comment 6

16 years ago
Created attachment 91199 [details] [diff] [review]
patch
(Assignee)

Comment 7

16 years ago
roy, could you r=?
(Assignee)

Comment 9

16 years ago
cc to rbs,
rbs, could you sr?

Comment 10

16 years ago
Comment on attachment 91199 [details] [diff] [review]
patch

sr=rbs
Attachment #91199 - Flags: superreview+
(Assignee)

Comment 11

16 years ago
fix checked in. 
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.