Font manipulation is platform specific issue. When we make any changes in API, we use ifdef to allow some platform to implement the change before other platforms. "NEW_FONT_HEIGHT_APIS" is one such example. Now it is defined (thus implemented) for XP_UNIX, XP_PC, XP_MAC, XP_BEOS. Is there any other platform missing? If not, it should be the right time to eliminate this flag and make it default? Since I didn't see OS2, I will like to ask mkaply to verify this on OS/2. mkaply, once this is done for OS2, please reassign it back to me.
XP_PC covers OS/2 and Windows
Assignee: mkaply → shanjian
Not OS/2 now.
OS: OS/2 → All
Hardware: PC → All
Yokoyama-san, could you please check this bug? feel free to reassign it back to IQA in case you need IQA's help.
QA Contact: ruixu → yokoyama
jim, do you know if there is any platform that are not covered by XP_UNIX, XP_PC, XP_MAC, XP_BEOS?
Status: NEW → ASSIGNED
No I think you have them all.
roy, could you r=?
Comment on attachment 91199 [details] [diff] [review] patch r=Roland.Mainz@informatik.med.uni-giessen.de Looks good... :)
Attachment #91199 - Flags: review+
cc to rbs, rbs, could you sr?
Comment on attachment 91199 [details] [diff] [review] patch sr=rbs
Attachment #91199 - Flags: superreview+
fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.