Closed
Bug 130091
Opened 22 years ago
Closed 22 years ago
should we get rid of "NEW_FONT_HEIGHT_APIS"
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
People
(Reporter: shanjian, Assigned: shanjian)
Details
(Keywords: intl)
Attachments
(1 file)
|
3.44 KB,
patch
|
roland.mainz
:
review+
rbs
:
superreview+
|
Details | Diff | Splinter Review |
Font manipulation is platform specific issue. When we make any changes in API, we use ifdef to allow some platform to implement the change before other platforms. "NEW_FONT_HEIGHT_APIS" is one such example. Now it is defined (thus implemented) for XP_UNIX, XP_PC, XP_MAC, XP_BEOS. Is there any other platform missing? If not, it should be the right time to eliminate this flag and make it default? Since I didn't see OS2, I will like to ask mkaply to verify this on OS/2. mkaply, once this is done for OS2, please reassign it back to me.
Yokoyama-san, could you please check this bug? feel free to reassign it back to IQA in case you need IQA's help.
Keywords: intl
QA Contact: ruixu → yokoyama
|
Assignee | |
Comment 4•22 years ago
|
||
jim, do you know if there is any platform that are not covered by XP_UNIX, XP_PC, XP_MAC, XP_BEOS?
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 6•22 years ago
|
||
|
|
Assignee | |
Comment 7•22 years ago
|
||
roy, could you r=?
|
||
Comment 8•22 years ago
|
||
Comment on attachment 91199 [details] [diff] [review] patch r=Roland.Mainz@informatik.med.uni-giessen.de Looks good... :)
Attachment #91199 -
Flags: review+
|
|
Assignee | |
Comment 9•22 years ago
|
||
cc to rbs, rbs, could you sr?
|
||
Comment 10•22 years ago
|
||
Comment on attachment 91199 [details] [diff] [review] patch sr=rbs
Attachment #91199 -
Flags: superreview+
|
|
Assignee | |
Comment 11•22 years ago
|
||
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•