Closed Bug 1300933 Opened 6 years ago Closed 6 years ago

Bogus forward declaration in TextureD3D9.h

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Platform:
All
Windows
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: mstange, Assigned: mstange)

Details

Attachments

(1 file)

Bug 1300933 - Remove unnecessary forward declaration of mozilla::gfxs::DrawTarget.
58 bytes, text/x-review-board-request
nical
: review+
Details 
gfx/layers/d3d9/TextureD3D9.h:
> namespace mozilla {
> namespace gfxs {
> class DrawTarget;
> }
> }

This file already includes 2D.h, and mozilla::gfxs is not the proper namespace.
(I found this by aimlessly looking through http://people.mozilla.org/~bgirard/doxygen/gfx/namespacemozilla.html )
Comment on attachment 8788705 [details]
Bug 1300933 - Remove unnecessary forward declaration of mozilla::gfxs::DrawTarget.

https://reviewboard.mozilla.org/r/77104/#review75384
Attachment #8788705 - Flags: review?(nical.bugzilla) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0abb41799b5b
Remove unnecessary forward declaration of mozilla::gfxs::DrawTarget. r=nical
https://hg.mozilla.org/mozilla-central/rev/0abb41799b5b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.