Bogus forward declaration in TextureD3D9.h

RESOLVED FIXED in Firefox 51

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
mozilla51
All
Windows
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
gfx/layers/d3d9/TextureD3D9.h:
> namespace mozilla {
> namespace gfxs {
> class DrawTarget;
> }
> }

This file already includes 2D.h, and mozilla::gfxs is not the proper namespace.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

2 years ago
(I found this by aimlessly looking through http://people.mozilla.org/~bgirard/doxygen/gfx/namespacemozilla.html )

Comment 3

2 years ago
mozreview-review
Comment on attachment 8788705 [details]
Bug 1300933 - Remove unnecessary forward declaration of mozilla::gfxs::DrawTarget.

https://reviewboard.mozilla.org/r/77104/#review75384
Attachment #8788705 - Flags: review?(nical.bugzilla) → review+

Comment 4

2 years ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0abb41799b5b
Remove unnecessary forward declaration of mozilla::gfxs::DrawTarget. r=nical

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0abb41799b5b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.