1301031 - NullPointerException: Attempt to invoke virtual method 'org.mozilla.gecko.icons.IconRequestBuilder > org.mozilla.gecko.icons.IconRequestBuilder.icon(org.mozilla.gecko.icons.IconDescriptor)'

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Favicon Handling, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

> handleMessage: Link:Favicon
> handleMessage threw for Link:Favicon
> java.lang.NullPointerException: Attempt to invoke virtual method 'org.mozilla.gecko.icons.IconRequestBuilder 
> org.mozilla.gecko.icons.IconRequestBuilder.icon(org.mozilla.gecko.icons.IconDescriptor)' on a null object reference
> at org.mozilla.gecko.Tab.addFavicon(Tab.java:439)
> at org.mozilla.gecko.Tabs.handleMessage(Tabs.java:525)
> at org.mozilla.gecko.EventDispatcher.dispatchEvent(EventDispatcher.java:411)
> at org.mozilla.gecko.EventDispatcher.dispatchEvent(EventDispatcher.java:246)
> at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:1971)
> at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
> at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:525)

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1301031 - Tab: Initialize icon request builder in constructor.

Review commit: https://reviewboard.mozilla.org/r/77200/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77200/

Comment 2

[Andrzej Hunt :ahunt]

Comment on attachment 8788860 [details]
Bug 1301031 - Tab: Initialize icon request builder in constructor.

https://reviewboard.mozilla.org/r/77200/#review75508

Comment 3

[Andrzej Hunt :ahunt]

Comment on attachment 8788860 [details]
Bug 1301031 - Tab: Initialize icon request builder in constructor.

https://reviewboard.mozilla.org/r/77200/#review75510

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d89d3f611e91
Tab: Initialize icon request builder in constructor. r=ahunt

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d89d3f611e91