1301173 - Changing the rustc std target requires a clobber

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

I pushed a change that touched some rust code, and it failed on inbound:
https://treeherder.mozilla.org/logviewer.html#?job_id=35483076&repo=mozilla-inbound#L3484
12:17:06     INFO -  error: can't find crate for `std` [E0463]
12:17:06     INFO -  error: aborting due to previous error
12:17:06     INFO -  error: Could not compile `gkrust`.
12:17:06     INFO -  Caused by:
12:17:06     INFO -    Process didn't exit successfully: `/builds/slave/m-in-lx-0000000000000000000000/build/src/rustc/bin/rustc /builds/slave/m-in-lx-0000000000000000000000/build/src/toolkit/library/rust/lib.rs --crate-name gkrust --crate-type staticlib -C opt-level=2 -C panic=abort -C lto -g -C metadata=7bec5ca2d425b47b --out-dir /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/toolkit/library/rust/./i686-unknown-linux-gnu/release/deps --emit=dep-info,link --target i686-unknown-linux-gnu -L dependency=/builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/toolkit/library/rust/./i686-unknown-linux-gnu/release/deps --extern mp4parse_capi=/builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/toolkit/library/rust/./i686-unknown-linux-gnu/release/deps/libmp4parse_capi.rlib` (exit code: 101)
12:17:06     INFO -  gmake[5]: *** [force-cargo-build] Error 101


This landed a few hours after rillian's rustc update. That build didn't run configure, so I wonder if we have an issue when we build a dep build that touches rust code on top of an existing objdir that used a different rustc versino?

Comment 1

[Mike Hommey [:glandium]]

The rustc update doesn't contain i686 target files, but has i585 target files instead. That requires configure to rerun to pickup the new target. So, in fact, this is a needs-clobber issue.

Comment 2

[(not currently active) Ted Mielczarek]

Ah, good call!

Comment 3

[Intermittent Failures Robot]

12 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 10
* mozilla-inbound: 1
* fx-team: 1

Platform breakdown:
* linux32: 9
* windows7-32-vm: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1301173&startday=2016-09-05&endday=2016-09-11&tree=all

Comment 4

[Ralph Giles (:rillian)]

Looks like we can close this. Even aside from clobber being appropriate above, we'd dropped i586 support, so it likely works with the toolchain package we have today.