1301174 - [META] Tracking bug for JS Debugger code coverage collection. (Disabled linux64-jsdcov build)

Status: NEW

(Testing :: Code Coverage, task)

Description

[Greg Mierzwinski [:sparky]]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160823121617

Comment 1

[Greg Mierzwinski [:sparky]]

This bug will be used to track all work that has to do with the JS Debugger code coverage and the linux64-jsdcov build.

Comment 2

[Greg Mierzwinski [:sparky]]

Are there other test suites that we are interested in instrumenting with per test js debugger code coverage?

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

I think web-platform-tests and maybe jsreftest, mochitest-clipboard, mochitest-webgl, mochitest-media, mochitest-gpu, mochitest-a11y.  That is most of the tests, I think we change enough stuff that we can re assess our coverage when we get done with that list.

Comment 4

[Greg Mierzwinski [:sparky]]

Ok, I'll make some bugs for those. Would marionette be another one we'd like to instrument?

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

I think so, we should at least try it out.

Comment 6

[Greg Mierzwinski [:sparky]]

I spent some time looking at marionette and it seems like it doesn't run any javascript tests even though it does have the capability to do so: https://dxr.mozilla.org/mozilla-central/source/testing/marionette/harness/marionette_harness/marionette_test/testcases.py#301 .

If we have javascript running inside the marionette python tests, then we'd have to find a way to hookup the coverage collector so that it can gather up that data.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

I would imagine much .js code inside the browser would be covered by marionette tests.

Comment 8

[Nicolas B. Pierron [:nbp]]

(In reply to Joel Maher ( :jmaher) from comment #7)
> I would imagine much .js code inside the browser would be covered by marionette tests.

There is an easy way to test that, you can run the full test suite with JS_CODE_COVERAGE_OUTPUT_DIR environment variable, which will dump one *.lcov file per JSRuntime instance.

You might still have issues as the child process is not properly closed, and the JSRuntime destructor is not closed properly.

Comment 9

[Greg Mierzwinski [:sparky]]

The linux64-jsdcov build has been disabled, and no longer runs in taskcluster, see bug 1496791. But the tooling still exists so that data can be obtained locally.

Comment 10

[Rajendra Alvarado]

Attachment: same problem

Thanks from backscenmarti1982.