130122 - IME doesn't work with netscape home page search field

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Yuying Long]

Build: 03-11 trunk build on all platforms.

Load page http://home.netscape.com, move mouse focus to search field, turn on
IME(JA, SCH or TCH), type somthing, nothing will show up into the field.

I don't see same problem in Mail, Composer and browser URL bar.
By going some other pages (e.g. yahoo.com, home.netscape.com/ja...etc) don't see
the same problem neither.

Not repro. it on IE, also seems it's a regression, I don't see it on N6.2.1.

Comment 1

[Yuying Long]

The regression was happened on sometime between 02-14 and 02-20.

Comment 2

[Frank Tang]

nsbeta1+ especially this is a regression. We are afraid there are other page
like this.

Comment 3

[Roy Yokoyama]

accepting

Comment 4

[Roy Yokoyama]

It looks like we are sending correct UNICODE text to DOM as NS_TEXT_EVENT.

Comment 5

[Roy Yokoyama]

Narrowing the builds it's between 2002-02-18-09-trunk and 2002-02-19-18-trunk

Comment 6

[Roy Yokoyama]

This isn't easy to find which checkin caused this problem.
There are so many checkins in the period.

Comment 7

[Frank Tang]

what kind of page will cause this problem ? it looks like other page have no
problem . Do we know what trigger this issue ?
adt3 for now

Comment 8

[Roy Yokoyama]

Netscape search doesn't show up anymore. (132673 and 123899 may be related.)

>what kind of page will cause this problem ?
As far as I know, the search text in http://home.netscape.com
has problem.  Other input texts (Quote, Weather-ZIP) are fine.

Comment 9

[Roy Yokoyama]

>Other input texts (Quote, Weather-ZIP) are fine.
I just pulled today's build and Quote/Weather text area
are not working most of the time.  I need help.

Comment 10

[Frank Tang]

this could be a focus issue. 
Can we reproduce this on mac?

Comment 11

[Frank Tang]

 Impact Summery
Impact Platform: ALL
Impact language users: CJK users 132.8 M 23.7%
Probability of hitting the problem: Not sure, we know at least home.netscape.com
have this problem. Not sure about other pages. Some top pages do not have the
problem. We are not sure what cause this right now.
Severity if hit the problem in the worst case: Cannot use it with Asian pages
for html FORM.
Way of recover after hit the problem: type the text in somewhere else and copy
and paste in to the form.
Risk of the fix: unknown
Potential benefit of fix this problem:  fix other pages.

Comment 12

[Rui Xu]

> Can we reproduce this on mac?
Yes, it is reproducible on MacOS9 and MacOSX.

Comment 13

[Roy Yokoyama]

Generic IME problem in netscape.com site.  Need help

Comment 14

[Masaki Katakai]

While debugging bug 52416, I found some questionable
codes in nsViewManager.cpp. The codes look
only key event, like

NS_IS_KEY_EVENT(aEvent)

but we usually look IME_EVENT. After I changed this
to

NS_IS_KEY_EVENT(aEvent) || NS_IS_IME_EVENT(aEvent)

it's now working for me. I've verified this works on
Solaris IME, not tried on Windows and Mac.

Also this should be evaluated by view/ folks carefully.

Comment 15

[Masaki Katakai]

Attachment: check NS_IS_IME_EVENT also

Comment 16

[Roy Yokoyama]

katakai-san: 
  Thank you for looking into this.
  This may be caused by Bug 91516 which is checked in 2002-02-19.
  (See my comment  #5)
  I'll see if this fixes the problem in Windows.

cc: kmcclusk,rods,attinas

Comment 17

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This patch looks like the right thing to me.

> -        else if (nsnull != mKeyGrabber && NS_IS_KEY_EVENT(aEvent)) {
> +        else if (nsnull != mKeyGrabber && (NS_IS_KEY_EVENT(aEvent) ||
> NS_IS_KEY_EVENT(aEvent))) {

I think you want to write "NS_IS_KEY_EVENT(aEvent) || NS_IS_IME_EVENT(aEvent)".

Fix that, and I'll give an r=roc+moz

By the way, do you guys know where I can download a free IME for XFree86 4, so I
can test this kind of stuff myself?

Comment 18

[Masaki Katakai]

sorry, my mistake....

Yokoyama-san, can you update the patch?

Robert, which distribution are you using?
You need the complete set of locale database
for Japanese on your system. I think recent
distribution such as redhat? or mandrake?
already contain japanese locale database
also include japanese IME... You can add
language for "Japanese" at the installation.

Comment 19

[Roy Yokoyama]

Attachment: Revised : fixing typo

Verified this patch fixes the problem in Windows. 
Thank you sooo much, katakai-san. :)

Comment 20

[Roy Yokoyama]

Comment on attachment 77536 [details] [diff] [review]
Revised : fixing typo

/r=yokoyama

Could someone please /sr=?

Comment 21

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 77536 [details] [diff] [review]
Revised : fixing typo

sr=roc+moz

Comment 22

[Asa Dotzler [:asa]]

Comment on attachment 77536 [details] [diff] [review]
Revised : fixing typo

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 23

[Roy Yokoyama]

adding adt1.0.0 keyword

Comment 24

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) for approvale to checkin.

Comment 25

[Roy Yokoyama]

checked in.
Thank you, Katakai-san :)

Comment 26

[Rui Xu]

Verify fixed on Win, Mac and Linux.