1301269 - Intermittent toolkit/components/url-classifier/tests/mochitest/test_gethash.html | Test timed out.

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=3238561&repo=autoland

https://queue.taskcluster.net/v1/task/BeTBsIKPQK-qAOJlBZp3zw/runs/0/artifacts/public%2Flogs%2Flive_backing.log

Comment 1

[François Marier [:francois]]

Dimi, is this something that should be fixed by your recent fixes to the tests?

Comment 2

[Dimi Lee [:dimi]]

It doesn't look like any of the problem solved recently.
I will check this.

Comment 3

[Dimi Lee [:dimi]]

I found the error occurs whiles regular update[1] happens when running test_gethash.html.
I am still investigating why it breaks test_gethash.

[1]https://dxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/content/listmanager.js#248

Comment 4

[Dimi Lee [:dimi]]

just an update that regular update may block test_gethash update[1], but for some reason the update retry[2] is not triggered so the testcase fail.

I'll keep checking.

[1] https://dxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp#1575
[2] https://dxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/tests/mochitest/classifierCommon.js#48

Comment 5

[Dimi Lee [:dimi]]

Sorry for not updating this bug for a while, the reproduce rate is really low so it did take more time to debug this.

What I have found so far is that the retry timer is released before triggering retry. I guess it might be related to the timer life cycle in javascript. I will keep working on this bug.

Comment 6

[Dimi Lee [:dimi]]

Attachment: Bug 1301269 - Fix update retry timer is released before firing.

Review commit: https://reviewboard.mozilla.org/r/87564/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87564/

Comment 7

[Dimi Lee [:dimi]]

After investigating, I think the root cause is that sometimes the timer is released by gc before it is fired.

Following is try result after applying the patch, i think it should be fixed because i have run the test more than 10000 times and it didn't happen again.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=76a5cc7d87f0&selectedJob=29618760

Comment 8

[François Marier [:francois]]

Comment on attachment 8803239 [details]
Bug 1301269 - Fix update retry timer is released before firing.

https://reviewboard.mozilla.org/r/87564/#review87408

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/382894f45be6
Fix update retry timer is released before firing. r=francois

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/382894f45be6

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/85a4c1dae591

Comment 12

[Ryan VanderMeulen [:RyanVM]]

I apparently forgot to mark the bug when uplifting this to Beta a couple weeks ago.
https://hg.mozilla.org/releases/mozilla-beta/rev/52b776e91075