Closed Bug 1301269 Opened 4 years ago Closed 4 years ago
_gethash .html | Test timed out .
58 bytes, text/x-review-board-request
Dimi, is this something that should be fixed by your recent fixes to the tests?
Priority: -- → P1
It doesn't look like any of the problem solved recently. I will check this.
Assignee: nobody → dlee
Status: NEW → ASSIGNED
I found the error occurs whiles regular update happens when running test_gethash.html. I am still investigating why it breaks test_gethash. https://dxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/content/listmanager.js#248
just an update that regular update may block test_gethash update, but for some reason the update retry is not triggered so the testcase fail. I'll keep checking.  https://dxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp#1575  https://dxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/tests/mochitest/classifierCommon.js#48
After investigating, I think the root cause is that sometimes the timer is released by gc before it is fired. Following is try result after applying the patch, i think it should be fixed because i have run the test more than 10000 times and it didn't happen again. https://treeherder.mozilla.org/#/jobs?repo=try&revision=76a5cc7d87f0&selectedJob=29618760
Comment on attachment 8803239 [details] Bug 1301269 - Fix update retry timer is released before firing. https://reviewboard.mozilla.org/r/87564/#review87408
Attachment #8803239 - Flags: review?(francois) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/382894f45be6 Fix update retry timer is released before firing. r=francois
I apparently forgot to mark the bug when uplifting this to Beta a couple weeks ago. https://hg.mozilla.org/releases/mozilla-beta/rev/52b776e91075
You need to log in before you can comment on or make changes to this bug.