Closed Bug 1301310 Opened 5 years ago Closed 4 years ago

[DateTimeInput] picker gets hidden/shown when clicking through inner text boxes

Categories

(Core :: Layout: Form Controls, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox51 --- affected
firefox55 --- fixed

People

(Reporter: jessica, Assigned: jessica)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Follow-up to Bug 1288591.

The default behavior of the panel is that it is hidden when user clicks outside of it. However, if the focus is still on the input box, we should not hide the panel, so we should consider using 'noautohide' and take care of the opening/closing of the panel ourselves.
Assignee: nobody → jjong
Comment on attachment 8859897 [details]
Bug 1301310 - Hide input date/time picker only when input element blurs.

Hey Scott, may I have your feedback first since I changed a little bit datetimepopup.xml code.
Attachment #8859897 - Flags: feedback?(scwwu)
Comment on attachment 8859897 [details]
Bug 1301310 - Hide input date/time picker only when input element blurs.

Thanks for the patch. I think it looks fine for datetimepopup.xml, as you are only re-ordering things.
Attachment #8859897 - Flags: feedback?(scwwu) → feedback+
Attachment #8859897 - Flags: review?(dtownsend)
Comment on attachment 8859897 [details]
Bug 1301310 - Hide input date/time picker only when input element blurs.

https://reviewboard.mozilla.org/r/131894/#review135352

::: toolkit/content/widgets/datetimebox.xml:1621
(Diff revision 1)
>          <body>
>          <![CDATA[
>            this.log("onKeyPress key: " + aEvent.key);
>  
>            switch (aEvent.key) {
>              // Close picker on Enter or Space key.

Update this comment please
Attachment #8859897 - Flags: review?(dtownsend) → review+
Comment on attachment 8859897 [details]
Bug 1301310 - Hide input date/time picker only when input element blurs.

https://reviewboard.mozilla.org/r/131894/#review135352

> Update this comment please

Will do, thanks.
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/01652f326a80
Hide input date/time picker only when input element blurs. r=mossop
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/01652f326a80
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.