[DateTimeInput] picker gets hidden/shown when clicking through inner text boxes

RESOLVED FIXED in Firefox 55

Status

()

Core
Layout: Form Controls
RESOLVED FIXED
11 months ago
4 months ago

People

(Reporter: jessica, Assigned: jessica)

Tracking

(Blocks: 1 bug)

Trunk
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 affected, firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
Follow-up to Bug 1288591.

The default behavior of the panel is that it is hidden when user clicks outside of it. However, if the focus is still on the input box, we should not hide the panel, so we should consider using 'noautohide' and take care of the opening/closing of the panel ourselves.
Blocks: 888320
(Assignee)

Updated

5 months ago
Assignee: nobody → jjong
Comment hidden (mozreview-request)
(Assignee)

Comment 2

4 months ago
Comment on attachment 8859897 [details]
Bug 1301310 - Hide input date/time picker only when input element blurs.

Hey Scott, may I have your feedback first since I changed a little bit datetimepopup.xml code.
Attachment #8859897 - Flags: feedback?(scwwu)

Comment 3

4 months ago
Comment on attachment 8859897 [details]
Bug 1301310 - Hide input date/time picker only when input element blurs.

Thanks for the patch. I think it looks fine for datetimepopup.xml, as you are only re-ordering things.
Attachment #8859897 - Flags: feedback?(scwwu) → feedback+
(Assignee)

Updated

4 months ago
Attachment #8859897 - Flags: review?(dtownsend)

Comment 4

4 months ago
mozreview-review
Comment on attachment 8859897 [details]
Bug 1301310 - Hide input date/time picker only when input element blurs.

https://reviewboard.mozilla.org/r/131894/#review135352

::: toolkit/content/widgets/datetimebox.xml:1621
(Diff revision 1)
>          <body>
>          <![CDATA[
>            this.log("onKeyPress key: " + aEvent.key);
>  
>            switch (aEvent.key) {
>              // Close picker on Enter or Space key.

Update this comment please
Attachment #8859897 - Flags: review?(dtownsend) → review+
(Assignee)

Comment 5

4 months ago
mozreview-review-reply
Comment on attachment 8859897 [details]
Bug 1301310 - Hide input date/time picker only when input element blurs.

https://reviewboard.mozilla.org/r/131894/#review135352

> Update this comment please

Will do, thanks.
Comment hidden (mozreview-request)
(Assignee)

Comment 7

4 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3476021da8e5b89e8be8b705b028e148089c137&group_state=expanded
Keywords: checkin-needed

Comment 8

4 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/01652f326a80
Hide input date/time picker only when input element blurs. r=mossop
Keywords: checkin-needed

Comment 9

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/01652f326a80
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.