Closed
Bug 130135
Opened 24 years ago
Closed 24 years ago
nsObserverList has a virtual destructor
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: alecf, Assigned: alecf)
Details
Attachments
(1 file)
|
597 bytes,
patch
|
dougt
:
review+
darin.moz
:
superreview+
roc
:
approval+
|
Details | Diff | Splinter Review |
I just noticed that nsObserverList is 12 bytes in size even though it only has 8
bytes of member variables.. then I noticed that it has a virtual destructor,
which gives it a vtable. It doesn't need this, it's just a concrete class, and
this will save it 8 bytes.
patch forthcoming.
|
Assignee | |
Comment 1•24 years ago
|
||
Can I get a r=dougt or r=dp?
|
|
||
Updated•24 years ago
|
Attachment #73585 -
Flags: superreview+
|
|
||
Comment 2•24 years ago
|
||
Comment on attachment 73585 [details] [diff] [review]
remove the "virtual"
sr=darin
|
|
||
Comment 3•24 years ago
|
||
Comment on attachment 73585 [details] [diff] [review]
remove the "virtual"
sr=darin
|
|
Assignee | |
Comment 4•24 years ago
|
||
(oh, I should add that this saves 4 bytes per nsObserverList - in the tinderbox
bloat tests, this is only about 104 bytes, but hey it was an easy fix)
|
||
Comment 5•24 years ago
|
||
Comment on attachment 73585 [details] [diff] [review]
remove the "virtual"
r=dougt.
Attachment #73585 -
Flags: review+
Comment on attachment 73585 [details] [diff] [review]
remove the "virtual"
a=roc+moz
Attachment #73585 -
Flags: approval+
|
|
Assignee | |
Comment 7•24 years ago
|
||
fix went in yesterday
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•