Landing patch of different author adds "r=me" instead of "r=reviewer"

RESOLVED DUPLICATE of bug 1299071

Status

MozReview
General
RESOLVED DUPLICATE of bug 1299071
a year ago
a year ago

People

(Reporter: sebastian, Unassigned)

Tracking

Production

Details

(URL)

(Reporter)

Description

a year ago
I wanted to land a patch of a contributor. Because I heavily use autoland I wanted to use it for that too.

I pushed the patch of the contributor to reviewboard (with r=sebastian), r+'ed it and then I wanted to land it. However reviewboard wants to land the patch with "r=me" appended to the commit message, even though I am not the author and reviewboard correctly shows the other author in the web interface.
"Fun" use case.

MozReview looks at the author of the MozReview review request instead of the commit metadata. This is because the commit metadata isn't authenticated (and can't be trusted) whereas the MozReview user is.

Until this bug gets fixed, next time, do one of the following:

a) have the contributor push to MozReview
b) mark the splinter patch as checkin-needed
c) push to inbound yourself
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1299071
You need to log in before you can comment on or make changes to this bug.