Closed Bug 1301363 Opened 8 years ago Closed 7 years ago

Search box responsive styling is broken on /all pages

Categories

(www.mozilla.org :: Pages & Content, defect)

Development/Staging
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: agibson, Assigned: rcmainak)

References

()

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

Attached image search.png
Probably another regression from the site-wide button overhaul
Context: https://github.com/mozilla/bedrock/pull/4326

I still think that the Search button should rather be hidden when JavaScript is enabled and find-as-you-type works, because it does nothing in that case; kinda bad UX. Will take a look.
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
Kohei, are you still working on this bug? I'd like to offer it up to contributors if you're busy with other things. Thanks
Flags: needinfo?(kohei.yoshino)
Freeing this one up for someone else to grab (thanks anyway Kohei).
Assignee: kohei.yoshino → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(kohei.yoshino)
Whiteboard: [good first bug]
Sorry, I could have a chance to work on it, but happy to see a contributor here of course :)
Assignee: nobody → mozilianmainak
Status: NEW → ASSIGNED
Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/17a14ecc780c6e8cae79e3c694754deb11900483
fix Bug 1301363 - fixed Search box responsive styling on /firefox/all page
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: