130137 - js_AddNativeProperty&js_ChangeNativePropertyAttrs fail to lock obj!

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brendan Eich [:brendan]]

This is a stupid oversight on my part.  These functions wrap js_AddScopeProperty
and js_ChangeScopePropertyAttributes, calling js_GetMutableScope first to ensure
that obj has its own scope.  They utterly fail to follow the locking protocol
and do what other such layers in jsobj.c on top of jsscope.c functions must do.
 Patch in a second, this is a must-fix for 1.0.

/be

Comment 1

[Brendan Eich [:brendan]]

Attachment: proposed fix

Thanks to chingfa for reporting this bug so quickly.  Looking for r= and sr=
from my bug 62164 patch-buddies.

/be

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 73588 [details] [diff] [review]
proposed fix

sr=shaver.

Comment 3

[Brendan Eich [:brendan]]

*** Bug 130138 has been marked as a duplicate of this bug. ***

Comment 4

[John Bandhauer]

Comment on attachment 73588 [details] [diff] [review]
proposed fix

r=jband. Looks right to me.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 73588 [details] [diff] [review]
proposed fix

a=roc+moz

Comment 6

[Brendan Eich [:brendan]]

Fixed.  Whew!

Thanks again to Chingfa.

/be