Closed
Bug 1301385
Opened 8 years ago
Closed 7 years ago
input type='search' subrole on OS X is wrong
Categories
(Core :: Disability Access APIs, defect, P5)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: surkov, Assigned: fedepad)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
regression from bug 1137714, see [1] Accessible::IsSearchField() should check for nsGkAtoms::search value instead nsGkAtoms::textInputType [1] https://hg.mozilla.org/mozilla-central/rev/5c47eaffd147#l5.17
Assignee | ||
Comment 1•7 years ago
|
||
(In reply to alexander :surkov from comment #0) > regression from bug 1137714, see [1] > > Accessible::IsSearchField() should check for nsGkAtoms::search value instead > nsGkAtoms::textInputType > > [1] https://hg.mozilla.org/mozilla-central/rev/5c47eaffd147#l5.17 Hi, as far as I've seen from the codebase, there is no Accessible::IsSearchField() but in the file you point to there is Accessible::IsSearchbox(). In this function you suggest to change nsGkAtoms::textInputType to nsGkAtoms::search. But shouldn't be nsGkAtoms::searchbox instead of your suggested nsGkAtoms::search? Is this the only change to be made? If that's the only change to be made I will prepare a patch and push for review. Thanks in advance for your reply.
Reporter | ||
Comment 2•7 years ago
|
||
(In reply to Federico Padua (fedepad) from comment #1) > (In reply to alexander :surkov from comment #0) > > regression from bug 1137714, see [1] > > > > Accessible::IsSearchField() should check for nsGkAtoms::search value instead > > nsGkAtoms::textInputType > > > > [1] https://hg.mozilla.org/mozilla-central/rev/5c47eaffd147#l5.17 > > Hi, as far as I've seen from the codebase, there is no > Accessible::IsSearchField() > but in the file you point to there is Accessible::IsSearchbox(). correct > In this function you suggest to change nsGkAtoms::textInputType to > nsGkAtoms::search. > But shouldn't be nsGkAtoms::searchbox instead of your suggested > nsGkAtoms::search? no, the check is supposed to detect input@type="search", see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input#Form_%3Cinput%3E_types > Is this the only change to be made? yes, we don't have OS X specific tests yet, so no tests for the change > If that's the only change to be made I will prepare a patch and push for > review. thanks!
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
Just pushed a patch for review.
Reporter | ||
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8849558 [details] Bug 1301385 - input type='search' subrole on OS X is wrong; https://reviewboard.mozilla.org/r/122338/#review124452 r=me, thanks
Attachment #8849558 -
Flags: review?(surkov.alexander) → review+
Assignee | ||
Comment 6•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8849558 [details] Bug 1301385 - input type='search' subrole on OS X is wrong; https://reviewboard.mozilla.org/r/122338/#review124452 You're welcome! You can trigger try builds or other stuff because I can't do it!
This bug appears to have a reviewed patch, shame it stalled out. Can someone get this committed?
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → federico_padua
Reporter | ||
Comment 8•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cbc882ea6aa3
Updated•7 years ago
|
Priority: -- → P5
Reporter | ||
Comment 9•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b39997a18705b9fe8fccd6bb8e29f57ec23d113 Bug 1301385 - input type='search' subrole on OS X is wrong, r=surkov
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7b39997a1870
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•