Closed Bug 1301473 Opened 4 years ago Closed 4 years ago

Backporting manifest updates is a huge pain

Categories

(Testing :: web-platform-tests, defect)

defect
Not set

Tracking

(firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: bzbarsky, Unassigned)

Details

Attachments

(1 file)

STEPS TO REPRODUCE:
1) Write a patch that adds web platform tests
2) Try to backport it.
3) Get merge failures in the manifest, not surprising.
4) Try to use "mach web-platform-tests-create" or "mach web-platform-tests --manifest-update" to update the manifest.

EXPECTED RESULTS: Manifest gets updated.

ACTUAL RESULTS: 

  Exception: Binary expected at /Users/bzbarsky/mozilla/aurora/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/firefox does not exist.

forcing me to build stuff I should have no reason to build.

I don't see why we need to have a Firefox binary just to update the manifest...
Flags: needinfo?(james)
Comment on attachment 8790289 [details]
Bug 1301473 - Add a wpt-manifest-update command,

bz: Does this seem like what you want?
Flags: needinfo?(james)
Yes, that is exactly what I want!
Comment on attachment 8790289 [details]
Bug 1301473 - Add a wpt-manifest-update command,

https://reviewboard.mozilla.org/r/78184/#review76672

Assuming it works...
Attachment #8790289 - Flags: review?(Ms2ger) → review+
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/b2166c12cbbe
Add a wpt-manifest-update command, r=Ms2ger
https://hg.mozilla.org/mozilla-central/rev/b2166c12cbbe
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.