1301481 - Don't allow double-closing of IPC channels

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

I spent a while last night debugging something where Close() was getting called twice on a top-level protocol. It's extra boilerplate we have to roll out each time, so we should probably just move it into MessageChannel.

Any objections, Bill?

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Err, the boilerplate being "check that we haven't already called Close or that ActorDestroy hasn't run".

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Sounds fine.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a706f77e10af
Don't allow double-closing of IPC channels. (bug 1301481, r=billm)

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a706f77e10af