Don't allow double-closing of IPC channels

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dvander, Assigned: dvander)

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

I spent a while last night debugging something where Close() was getting called twice on a top-level protocol. It's extra boilerplate we have to roll out each time, so we should probably just move it into MessageChannel.

Any objections, Bill?
Flags: needinfo?(wmccloskey)
Err, the boilerplate being "check that we haven't already called Close or that ActorDestroy hasn't run".
Sounds fine.
Flags: needinfo?(wmccloskey)
Posted patch patchSplinter Review
Attachment #8790577 - Flags: review?(wmccloskey)
Attachment #8790577 - Flags: review?(wmccloskey) → review+

Comment 4

3 years ago
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a706f77e10af
Don't allow double-closing of IPC channels. (bug 1301481, r=billm)

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a706f77e10af
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.