Closed Bug 1301481 Opened 4 years ago Closed 4 years ago

Don't allow double-closing of IPC channels

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: dvander, Assigned: dvander)

Details

Attachments

(1 file)

I spent a while last night debugging something where Close() was getting called twice on a top-level protocol. It's extra boilerplate we have to roll out each time, so we should probably just move it into MessageChannel.

Any objections, Bill?
Flags: needinfo?(wmccloskey)
Err, the boilerplate being "check that we haven't already called Close or that ActorDestroy hasn't run".
Sounds fine.
Flags: needinfo?(wmccloskey)
Attached patch patchSplinter Review
Attachment #8790577 - Flags: review?(wmccloskey)
Attachment #8790577 - Flags: review?(wmccloskey) → review+
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a706f77e10af
Don't allow double-closing of IPC channels. (bug 1301481, r=billm)
https://hg.mozilla.org/mozilla-central/rev/a706f77e10af
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.