[geckoview] Remove FormAssistPopup references in geckoview

RESOLVED FIXED in Firefox 51

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

unspecified
Firefox 51
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
This includes GeckoInterface.getFormAssistPopup() and its usage in GeckoInputConnection.
(Assignee)

Comment 1

2 years ago
Created attachment 8789566 [details] [diff] [review]
Remove FormAssistPopup dependency in geckoview (v1)

Remove the input method change notification that GeckoInputConnection
sends to FormAssistPopup, so there's no dependency on FormAssistPopup
from inside GeckoInputConnection or GeckoInterface. Instead,
FormAssistPopup now actively queries the current input method, and
performs blocklisting based on that.
Attachment #8789566 - Flags: review?(s.kaspari)
Attachment #8789566 - Flags: review?(s.kaspari) → review+
(Assignee)

Updated

2 years ago
Summary: Remove FormAssistPopup references in geckoview → [geckoview] Remove FormAssistPopup references in geckoview

Comment 2

2 years ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7fe478cdf45a
Remove FormAssistPopup dependency in geckoview; r=sebastian

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7fe478cdf45a
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.