Closed Bug 1301515 Opened 3 years ago Closed 3 years ago

[geckoview] Remove FormAssistPopup references in geckoview

Categories

(GeckoView :: General, defect)

All
Android
defect
Not set

Tracking

(firefox51 fixed)

RESOLVED FIXED
Tracking Status
firefox51 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(1 file)

This includes GeckoInterface.getFormAssistPopup() and its usage in GeckoInputConnection.
Remove the input method change notification that GeckoInputConnection
sends to FormAssistPopup, so there's no dependency on FormAssistPopup
from inside GeckoInputConnection or GeckoInterface. Instead,
FormAssistPopup now actively queries the current input method, and
performs blocklisting based on that.
Attachment #8789566 - Flags: review?(s.kaspari)
Attachment #8789566 - Flags: review?(s.kaspari) → review+
Summary: Remove FormAssistPopup references in geckoview → [geckoview] Remove FormAssistPopup references in geckoview
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7fe478cdf45a
Remove FormAssistPopup dependency in geckoview; r=sebastian
https://hg.mozilla.org/mozilla-central/rev/7fe478cdf45a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 51 → ---
You need to log in before you can comment on or make changes to this bug.