Closed
Bug 1301515
Opened 9 years ago
Closed 9 years ago
[geckoview] Remove FormAssistPopup references in geckoview
Categories
(GeckoView :: General, defect)
Tracking
(firefox51 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(1 file)
|
11.53 KB,
patch
|
sebastian
:
review+
|
Details | Diff | Splinter Review |
This includes GeckoInterface.getFormAssistPopup() and its usage in GeckoInputConnection.
|
Assignee | |
Comment 1•9 years ago
|
||
Remove the input method change notification that GeckoInputConnection
sends to FormAssistPopup, so there's no dependency on FormAssistPopup
from inside GeckoInputConnection or GeckoInterface. Instead,
FormAssistPopup now actively queries the current input method, and
performs blocklisting based on that.
Attachment #8789566 -
Flags: review?(s.kaspari)
|
||
Updated•9 years ago
|
Attachment #8789566 -
Flags: review?(s.kaspari) → review+
|
|
Assignee | |
Updated•9 years ago
|
Summary: Remove FormAssistPopup references in geckoview → [geckoview] Remove FormAssistPopup references in geckoview
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7fe478cdf45a
Remove FormAssistPopup dependency in geckoview; r=sebastian
|
||
Comment 3•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
|
||
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•6 years ago
|
Target Milestone: Firefox 51 → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•