1301569 - Fix tooltips for titlebar-buttons (min, max, close) on Windows 10

Status: NEW

(Firefox :: Toolbars and Customization, defect, P3)

Description

[magicp]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160908030434

Steps to reproduce:

1. Start Nightly on Windows 10
2. Mouse over on titlebar-buttons (min, max, close)
3. Check tooltips


Actual results:

tooltips for titlebar-buttons (min, max, close) are not displayed.


Expected results:

Fix tooltips for titlebar-buttons (min, max, close) on Windows 10.

Comment 1

[:Gijs (he/him)]

This will require string changes, so wontfix for all branches except current trunk. Considering we've shipped this for many releases already, I don't think it's a priority, so I'm marking P3.

Comment 2

[Edo Karabas]

Speaking of tooltips, the Library window (where you can see last downloaded files) has tooltips for all windows control buttons and fully localized. The same applies to any popup windows. So it's a bit interesting to see issues with the implementation for main Firefox window.

Comment 3

[:Gijs (he/him)]

(In reply to Eddward from comment #2)
> Speaking of tooltips, the Library window (where you can see last downloaded
> files) has tooltips for all windows control buttons and fully localized. The
> same applies to any popup windows. So it's a bit interesting to see issues
> with the implementation for main Firefox window.

We provide our own window controls for the main window, in order to implement tabs-in-the-titlebar on Windows 10 (and integrate with lightweight themes, etc. etc.). This is why they need separate tooltips and why things work normally in windows that don't have the tabstrip in the titlebar, like the library and popup windows.

Comment 4

[Edo Karabas]

Ah yes, I see. Thanks for explanation, so we can let the bug sleep again :)

Comment 5

[Big Muscle]

(In reply to :Gijs (away until Nov 20) from comment #3)
> (In reply to Eddward from comment #2)
> > Speaking of tooltips, the Library window (where you can see last downloaded
> > files) has tooltips for all windows control buttons and fully localized. The
> > same applies to any popup windows. So it's a bit interesting to see issues
> > with the implementation for main Firefox window.
> 
> We provide our own window controls for the main window, in order to
> implement tabs-in-the-titlebar on Windows 10 (and integrate with lightweight
> themes, etc. etc.). This is why they need separate tooltips and why things
> work normally in windows that don't have the tabstrip in the titlebar, like
> the library and popup windows.

Sorry to say it, but this is the totally silly reason. Drawing anything (e.g. tabs) in the titlebar works correctly on WinVista, Win7, Win8.x and Win10 in the same way. There is absolutely no reason to do anything different on Win10. The only actual reason is that Firefox tries to simulate Win10 UWP theme and does not respect the used system theme. If Firefox does not render its own titlebar/buttons on Win10, everything will still work correctly and it will even match the used system theme.