1301666 - Remove triggeringPrincipal_b64 from SessionHistory.jsm

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P3)

Description

[Christoph Kerschbaumer [:ckerschb]]

Bug 1297338 introduces the concept of a principalToInherit which is basically the equivalent of the current triggeringPrincipal. After a few cycles (once principalToInherit is well established) we should update:
* browser/components/sessionstore/SessionHistory.jsm
* mobile/android/components/SessionStore.js

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

The new code will use the variables
* triggeringPrincipal_base64, and
* principalToInherit_base64

After a few cycles (e.g. within FF53 or FF55) we can remove:
* triggeringPrincipal_b64

Comment 2

[Jan Henning [:JanH]]

Android now uses SessionHistory.jsm as well, so removing this from there will be sufficient.

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Jan Henning [:JanH] from comment #2)
> Android now uses SessionHistory.jsm as well, so removing this from there
> will be sufficient.

Thanks for the update Jan - in fact, I think we can get that code updated now.

Comment 4

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1301666_remove_triggeringprincipal_b64_from_sessionhistory.patch

Mike, we landed Bug 1297338 within FF52. I think we can remove triggeringPrincipal_b64 now - what do you think?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5882ea27723695484a9388b8928f3878f4bd2351

Comment 5

[Mike de Boer [:mikedeboer]]

Comment on attachment 8846535 [details] [diff] [review]
bug_1301666_remove_triggeringprincipal_b64_from_sessionhistory.patch

Review of attachment 8846535 [details] [diff] [review]:
-----------------------------------------------------------------

Yay for code removal!

::: toolkit/modules/sessionstore/SessionHistory.jsm
@@ +403,5 @@
>        }
>      }
>  
> +    if (entry.triggeringPrincipal_base64) {
> +      shEntry.triggeringPrincipal =

nit: Please make these two one-liners.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/423b156372ea
Remove triggeringPrincipal_b64 from SessionHistory.jsm. r=mikedeboer

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/423b156372ea