Closed
Bug 1301700
Opened 8 years ago
Closed 8 years ago
Don't retry logs that fail due to UnicodeDecodeError
Categories
(Tree Management :: Treeherder: Data Ingestion, defect, P2)
Tree Management
Treeherder: Data Ingestion
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
eg: https://rpm.newrelic.com/accounts/677903/applications/4180461/traced_errors/7f0b95fa-75e9-11e6-a90b-b82a72d22a14_0_6445 ... File "/data/www/treeherder.mozilla.org/treeherder-service/treeherder/workers/task.py", line 32, in inner File "/data/www/treeherder.mozilla.org/treeherder-service/treeherder/workers/taskset.py", line 24, in inner File "/data/www/treeherder.mozilla.org/treeherder-service/treeherder/log_parser/tasks.py", line 35, in inner File "/data/www/treeherder.mozilla.org/treeherder-service/treeherder/log_parser/tasks.py", line 105, in parse_log File "/data/www/treeherder.mozilla.org/treeherder-service/treeherder/log_parser/utils.py", line 44, in post_log_artifacts File "/data/www/treeherder.mozilla.org/treeherder-service/treeherder/log_parser/utils.py", line 29, in extract_text_log_artifacts File "/data/www/treeherder.mozilla.org/venv/lib/python2.7/site-packages/simplejson/__init__.py", line 380, in dumps File "/data/www/treeherder.mozilla.org/venv/lib/python2.7/site-packages/simplejson/encoder.py", line 275, in encode File "/data/www/treeherder.mozilla.org/venv/lib/python2.7/site-packages/simplejson/encoder.py", line 357, in iterencode exceptions:UnicodeDecodeError: 'utf8' codec can't decode bytes in position 498-499: unexpected end of data
Comment 1•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8790293 -
Flags: review?(wlachance)
Comment 2•8 years ago
|
||
Comment on attachment 8790293 [details] [review] [treeherder] mozilla:no-retry-unicodedecodeerror > mozilla:master This is fine, though I feel like we should have designed this so we had a whitelist of retryable exceptions, rather than the reverse. Anyway, thanks for the fix!
Attachment #8790293 -
Flags: review?(wlachance) → review+
Comment 3•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/2c1ed9df541c66229cdb5ea4d56b9585d0840b5c Bug 1301700 - Don't retry tasks that fail due to UnicodeDecodeError Since the task will fail every time.
Assignee | ||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•