1301716 - Pref off new debugger in tests that require old debugger

Status: RESOLVED DUPLICATE of bug 1300861

(DevTools :: Debugger, defect)

Description

[James Long (:jlongster)]

There are several older tests in other tools that assume the window has state that the older debugger created. We need to fix up these tests, but we want to turn on the new debugger now so we're going to just force those specific tests to keep using the old debugger.

Comment 1

[James Long (:jlongster)]

Attachment: 1301716.patch

Fixes the following tests:

devtools/client/webconsole/test/browser_console_optimized_out_vars.js
devtools/client/webconsole/test/browser_console_variables_view_while_debugging.js
devtools/client/webconsole/test/browser_console_variables_view_while_debugging_and_inspecting.js 
devtools/client/webconsole/test/browser_eval_in_debugger_stackframe.js
devtools/client/webconsole/test/browser_eval_in_debugger_stackframe2.js
devtools/client/webconsole/test/browser_webconsole_autocomplete_in_debugger_stackframe.js
devtools/client/webconsole/test/browser_webconsole_bug_1050691_click_function_to_source.js
devtools/client/webconsole/test/browser_webconsole_bug_766001_JS_Console_in_Debugger.js
devtools/client/webconsole/test/browser_webconsole_closure_inspection.js 
devtools/client/webconsole/test/browser_webconsole_input_field_focus_on_panel_select.js

Comment 2

[James Long (:jlongster)]

When we run a try push, we'll should include bug 1301719 which fixes a bunch of browser toolbox/addons tests.

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: Bug 1301716 - Use old debugger in a few tests in other tools (part 1)

Review commit: https://reviewboard.mozilla.org/r/77938/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77938/

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: Bug 1301716 - Pref off new debugger in tests that require old debugger

Review commit: https://reviewboard.mozilla.org/r/77940/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77940/

Comment 5

[Brian Grinstead [:bgrins]]

Try push with these patches + bug 1301719 + bug 1300861: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0492127466e9

Comment 6

[James Long (:jlongster)]

Let's merge this with bug 1300861, as it's difficult to track a lot of moving parts.