1301729 - Stop using / storing buildapi artifacts

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[William Lachance (:wlach)]

For buildbot jobs, we currently store "buildapi" artifacts with two pieces of information:

* The buildername
* The buildbot request id (if one exists)

As part of the migration away from artifacts, I'd like to get rid of these.

The buildername is currently stored as the job property "ref_data_name", so is redundant. 

The request id can just be stored as a "job detail" I think.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1301729 > mozilla:master

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8789910 [details] [review]
[treeherder] wlach:1301729 > mozilla:master

This turned out to be pretty easy. Storing this information as part of the job details is a bit of a hack, but I think it seems to work ok.

Comment 3

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/546b971ad260d688d36233847be8852b34c1fd29
Bug 1301729 - Allow filtering job details by title through API

https://github.com/mozilla/treeherder/commit/d29527e96a0693341a2abe9486ed328de565ec40
Bug 1301729 - Add a migration script for moving buildapi artifacts -> job details

https://github.com/mozilla/treeherder/commit/7e4ec3423ed327b9c8da856b51759e15f75ea997
Bug 1301729 - Store buildbot request id as a job detail

https://github.com/mozilla/treeherder/commit/58681ac38d595d2a1c7f9f16538cd412c0f06d77
Merge pull request #1840 from wlach/1301729

Bug 1301729 - Store buildbot request id as a job detail

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2b3ebbcfa9300610f212257a944d48437efb52c6
Bug 1301729 - Fix up migration script for some edge cases

Comment 5

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1301729-followup > mozilla:master

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 8791380 [details] [review]
[treeherder] wlach:1301729-followup > mozilla:master

r+ with the test fix

Comment 7

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e4b30bf43a5f9ef8668dcfef6d8f2621e83ab4be
Bug 1301729 - Stop storing buildapi artifacts

https://github.com/mozilla/treeherder/commit/246e11b11decd6ff593873aa5d07d33209a6d4da
Bug 1301729 - Remove buildapi migration script

https://github.com/mozilla/treeherder/commit/b6558c822d2ce51fa885b350f94ba09571c61e50
Merge pull request #1855 from wlach/1301729-followup

Bug 1301729 - Followups to buildapi artifact deprecation

Comment 8

[William Lachance (:wlach)]

I accidentally missed some code that still grabbed this information from the artifact model for classification mirroring to ES/OrangeFactor. Reopening.

Comment 9

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1301729-followup2 > mozilla:master

Comment 10

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/c35d9fd56ff1c4c5006d60e5d773940ecca9e961
Bug 1301729 - Use job's ref_data_name for buildname w/ classification mirroring (#1952)

Comment 11

[William Lachance (:wlach)]

Re-resolving.