Closed Bug 1301770 Opened 3 years ago Closed 3 years ago

dismiss mutation events if their container has been shown or hidden afterwards

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: surkov, Assigned: surkov)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
addition to bug 1295603, make sure to dismiss mutation events if their contains was shown or hidden afterwards. We do that currently, but we do not check grand children and all sub events.

the patch contains todo_invokerCheker changes too: todo should pass, if todo event was handled but in incorrect order
Attachment #8789908 - Flags: review?(yzenevich)
Comment on attachment 8789908 [details] [diff] [review]
patch

Review of attachment 8789908 [details] [diff] [review]:
-----------------------------------------------------------------

thanks

::: accessible/tests/mochitest/events.js
@@ +352,2 @@
>                    if (checker.todo) {
> +                    todo(false, `Todo event '${typeStr}' was caught`);

Is there a reason you don't use this style in the other two cases?
Attachment #8789908 - Flags: review?(yzenevich) → review+
(In reply to Yura Zenevich [:yzen] from comment #1)

> >                    if (checker.todo) {
> > +                    todo(false, `Todo event '${typeStr}' was caught`);
> 
> Is there a reason you don't use this style in the other two cases?

nope, I'll fix those lines
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b8f24e60b5dcb7932755bb698d151e166d10cf1
Bug 1301770 - dismiss mutation events if their container has been shown or hidden afterwards, r=yzen
https://hg.mozilla.org/mozilla-central/rev/9b8f24e60b5d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee: nobody → surkov.alexander
You need to log in before you can comment on or make changes to this bug.