Closed
Bug 1301815
Opened 8 years ago
Closed 8 years ago
Delete all snapshots button in memory tools should be disabled while there are no snapshots taken
Categories
(DevTools :: Memory, defect, P3)
Tracking
(firefox52 verified)
VERIFIED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | verified |
People
(Reporter: Towkir, Assigned: Towkir, Mentored)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
771 bytes,
patch
|
ntim
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
||
Updated•8 years ago
|
Mentor: ntim.bugs
Keywords: good-first-bug
|
|
||
Comment 1•8 years ago
|
||
So the code for the clear snapshots button is here: https://dxr.mozilla.org/mozilla-central/source/devtools/client/memory/components/toolbar.js#247 You can get inspired by the code for the diff snapshots button (which is a bit further down in the same file) for how to disable it and detect the number of snapshots. Let me know if you need extra info :)
Flags: needinfo?(3ugzilla)
|
||
Updated•8 years ago
|
Blocks: memory-frontend
Priority: -- → P3
|
Assignee | |
Comment 2•8 years ago
|
||
Thanks Tim, I will soon look into it, and will let you know if I need anything :) assigning for now
Assignee: nobody → 3ugzilla
Status: NEW → ASSIGNED
Flags: needinfo?(3ugzilla)
|
|
||
Comment 3•8 years ago
|
||
So at https://dxr.mozilla.org/mozilla-central/source/devtools/client/memory/components/toolbar.js#247 You'll need to add: disabled: !snapshots.length,
|
|
Assignee | |
Comment 4•8 years ago
|
||
Thanks Tim, for figuring this out for me. Though I was busy with exams, thought it should be done now with that solution. hope the patch helps :)
Attachment #8802998 -
Flags: review?(ntim.bugs)
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8802998 [details] [diff] [review] snapshot_button_memorytool.patch Review of attachment 8802998 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch, works fine to me!
Attachment #8802998 -
Flags: review?(ntim.bugs) → review+
|
|
||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2c8e364b56e1 Delete all snapshots button in memory tools has been disabled while there are no snapshots taken. r=ntim
Keywords: checkin-needed
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2c8e364b56e1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
||
Comment 8•8 years ago
|
||
This bug was about to disable " Delete all snapshots button " in memory tools while there are no snapshots taken. I have seen the feature being implemented with latest Nightly 52.0a1 on Windows 7 , 64 Bit ! This bug's fix is now verified in Latest Nightly 52.0a1 Build ID : 20161025030205 User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0 [bugday-20161026]
|
|
||
Updated•8 years ago
|
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•