1301864 - Invalid constexpr specifiers in Value.h?

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[André Bargull [:anba]]

In js/public/Value.h

Value CanonicalizedDoubleValue(double d)
- CanonicalizedDoubleValue is marked as constexpr, but it uses mozilla::IsNaN which calls mozilla::BitwiseCast, and BitCast isn't constexpr, which means CanonicalizedDoubleValue can't be constexpr.
- And even if the call to mozilla::IsNaN is replaced with `d != d` to make CanonicalizedDoubleValue constexpr, we can only access the asDouble member from jsval_layout in a constexpr context, because asBits isn't initialized. 

Value NumberValue(uint32_t i)
- NumberValue is marked constexpr, but it calls CanonicalizedDoubleValue which isn't constexpr per above.

Comment 1

[Tooru Fujisawa [:arai]]

Will fix after bug 1304191.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Part 1: Remove constexpr from mozilla::IsNaN.

for now, removing constexpr from mozilla::IsNaN here.
others may be handled in bug 1311088.

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 8803688 [details] [diff] [review]
Part 1: Remove constexpr from mozilla::IsNaN.

Review of attachment 8803688 [details] [diff] [review]:
-----------------------------------------------------------------

Sest la vee.

Comment 4

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/83ab2e59b7b537e420ba8aab75544a287686476a
Bug 1301864 - Remove constexpr from mozilla::IsNaN. r=jwalden

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/83ab2e59b7b5