1301981 - Add devtools code coverage collection to linux64-jsdcov.

Status: RESOLVED FIXED

(Testing :: Code Coverage, defect)

Description

[Greg Mierzwinski [:sparky]]

This should be done in the same way as mochitest-bc and a new flavor will have to created to enable the code coverage collection, something similar to "browser-chrome-coverage".

Comment 1

[Greg Mierzwinski [:sparky]]

Attachment: Bug 1301981 - Add devtools test task definition to linux64-jsdcov.

This patch provides the implementation that makes it possible to run the devtools test suite with the linux64-jsdcov build to collect js code coverage.

Review commit: https://reviewboard.mozilla.org/r/89862/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89862/

Comment 2

[Greg Mierzwinski [:sparky]]

Here's an example run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b3dd21d8f64f0cf33c2f3088d5ad2455eb025b6

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Patch looks ok to me, but there may be some subtleties to the taskcluster stuff I wouldn't catch, so let's have Joel sign off on it as well.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8806478 [details]
Bug 1301981 - Add devtools test task definition to linux64-jsdcov.

https://reviewboard.mozilla.org/r/89862/#review90110

::: testing/mozharness/configs/unittests/linux_unittest.py:197
(Diff revision 1)
>          "browser-chrome-coverage": ["--flavor=browser", "--chunk-by-runtime", "--timeout=1200"],
>          "browser-chrome-screenshots": ["--flavor=browser", "--subsuite=screenshots"],
>          "mochitest-gl": ["--subsuite=webgl"],
>          "mochitest-devtools-chrome": ["--flavor=browser", "--subsuite=devtools"],
>          "mochitest-devtools-chrome-chunked": ["--flavor=browser", "--subsuite=devtools", "--chunk-by-runtime"],
> +        "mochitest-devtools-chrome-coverage": ["--flavor=browser", "--subsuite=devtools", "--chunk-by-runtime", "--timeout=1200"],

do we need some other flags here to run jsdcoverage?

Comment 5

[Greg Mierzwinski [:sparky]]

Comment on attachment 8806478 [details]
Bug 1301981 - Add devtools test task definition to linux64-jsdcov.

https://reviewboard.mozilla.org/r/89862/#review90110

> do we need some other flags here to run jsdcoverage?

This part only changes some run options like the extra timeout. In the other modified file, this new flavor is used to determine whether or not code coverage should be turned on. If you take a look at the treeherder link I posted in the bug, it has an example run which generates the code coverage.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8806478 [details]
Bug 1301981 - Add devtools test task definition to linux64-jsdcov.

https://reviewboard.mozilla.org/r/89862/#review90192

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a195a9d6e901
Add devtools test task definition to linux64-jsdcov. r=jmaher

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a195a9d6e901