Remove leftover includes from bug 855407 (io.h and fcntl.h) from nsBrowserApp.cpp

RESOLVED FIXED in Firefox 51

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jorgk, Assigned: jorgk)

Tracking

Trunk
Firefox 51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
io.h and fcntl.h were added here:
https://hg.mozilla.org/mozilla-central/rev/fb6b33021e5a#l1.12
but never removed again. They are unnecessary.
(Assignee)

Comment 1

2 years ago
Created attachment 8790119 [details] [diff] [review]
1301987.patch

This also fixed an indentation issue which violates the coding standards.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8790119 - Flags: review?(jmathies)
Component: General → General
Product: Firefox for Metro → Firefox

Updated

2 years ago
Attachment #8790119 - Flags: review?(jmathies) → review+
(Assignee)

Comment 2

2 years ago
Thanks, Jim.

You might ask why this clean-up. I'm from the Thunderbird team and we were just aligning our main() function with the one from Firefox in bug 1289149. There we noticed some minor nits.
Keywords: checkin-needed

Comment 3

2 years ago
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/395b05f7d02e
removed unused io.h and fcntl.h. r=jimm
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/395b05f7d02e
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.