Closed Bug 1301987 Opened 4 years ago Closed 4 years ago

Remove leftover includes from bug 855407 (io.h and fcntl.h) from nsBrowserApp.cpp

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

Details

Attachments

(1 file)

io.h and fcntl.h were added here:
https://hg.mozilla.org/mozilla-central/rev/fb6b33021e5a#l1.12
but never removed again. They are unnecessary.
Attached patch 1301987.patchSplinter Review
This also fixed an indentation issue which violates the coding standards.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8790119 - Flags: review?(jmathies)
Product: Firefox for Metro → Firefox
Attachment #8790119 - Flags: review?(jmathies) → review+
Thanks, Jim.

You might ask why this clean-up. I'm from the Thunderbird team and we were just aligning our main() function with the one from Firefox in bug 1289149. There we noticed some minor nits.
Keywords: checkin-needed
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/395b05f7d02e
removed unused io.h and fcntl.h. r=jimm
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/395b05f7d02e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.