1302006 - Move the code of MDSM::SetDormant to various state objects

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1302006. Part 1 - Let DormantState handle dormant request.

Review commit: https://reviewboard.mozilla.org/r/79426/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79426/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1302006. Part 2 - Let ShutdownState handle dormant request.

Review commit: https://reviewboard.mozilla.org/r/79428/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79428/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1302006. Part 3 - Let SeekingState handle dormant request.

Review commit: https://reviewboard.mozilla.org/r/79430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79430/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1302006. Part 4 - Let StateObject handle dormant request.

Review commit: https://reviewboard.mozilla.org/r/79432/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79432/

Comment 5

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8792369 [details]
Bug 1302006. Part 2 - Let ShutdownState handle dormant request.

https://reviewboard.mozilla.org/r/79428/#review78038

Comment 6

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8792370 [details]
Bug 1302006. Part 3 - Let SeekingState handle dormant request.

https://reviewboard.mozilla.org/r/79430/#review78048

Comment 7

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8792368 [details]
Bug 1302006. Part 1 - Let DormantState handle dormant request.

https://reviewboard.mozilla.org/r/79426/#review78052

Comment 8

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8792371 [details]
Bug 1302006. Part 4 - Let StateObject handle dormant request.

https://reviewboard.mozilla.org/r/79432/#review78066

::: dom/media/MediaDecoderStateMachine.cpp:231
(Diff revision 1)
> -  virtual bool HandleDormant(bool aDormant) { return false; }
> +  virtual bool HandleDormant(bool aDormant)
> +  {
> +    if (!aDormant) {
> +      return true;
> +    }
> +    SLOG("Enter dormant state");

I don't think we need this message here. This information will be shown by this log  "DECODER_LOG("MDSM state: %s -> %s", ToStateStr(), ToStateStr(aState));" in |SetState|.

Unless you want to identify which StateObject is handling dormant, if so, we should add smiliar messages in other StateObject's HandleDormant, i.e.  SeekingState in Part3.

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8792371 [details]
Bug 1302006. Part 4 - Let StateObject handle dormant request.

https://reviewboard.mozilla.org/r/79432/#review78282

::: dom/media/MediaDecoderStateMachine.cpp:231
(Diff revision 1)
> -  virtual bool HandleDormant(bool aDormant) { return false; }
> +  virtual bool HandleDormant(bool aDormant)
> +  {
> +    if (!aDormant) {
> +      return true;
> +    }
> +    SLOG("Enter dormant state");

Will remove this log.

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8792371 [details]
Bug 1302006. Part 4 - Let StateObject handle dormant request.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79432/diff/1-2/

Comment 11

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8792371 [details]
Bug 1302006. Part 4 - Let StateObject handle dormant request.

https://reviewboard.mozilla.org/r/79432/#review78290

Cool work !

Comment 12

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fb80e9897fa
Part 1 - Let DormantState handle dormant request. r=kikuo
https://hg.mozilla.org/integration/autoland/rev/66359c23a6b6
Part 2 - Let ShutdownState handle dormant request. r=kikuo
https://hg.mozilla.org/integration/autoland/rev/c12f64bf2598
Part 3 - Let SeekingState handle dormant request. r=kikuo
https://hg.mozilla.org/integration/autoland/rev/e1bf663363fd
Part 4 - Let StateObject handle dormant request. r=kikuo

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7fb80e9897fa
https://hg.mozilla.org/mozilla-central/rev/66359c23a6b6
https://hg.mozilla.org/mozilla-central/rev/c12f64bf2598
https://hg.mozilla.org/mozilla-central/rev/e1bf663363fd