Closed
Bug 1302062
Opened 8 years ago
Closed 8 years ago
Switch recording list to React component for perf tool
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox52 fixed)
RESOLVED
FIXED
Firefox 52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: ntim, Assigned: gregtatum)
References
Details
Attachments
(1 file, 2 obsolete files)
No description provided.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gtatum
Assignee | ||
Updated•8 years ago
|
Priority: -- → P2
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•8 years ago
|
||
Comment 8•8 years ago
|
||
mozreview-review |
Comment on attachment 8792906 [details]
Bug 1302062 - Use React on performance recording list;
https://reviewboard.mozilla.org/r/79770/#review78798
Looks good! Great comments in the RecordingsView too, w/r/t migration.
Attachment #8792906 -
Flags: review?(jsantell) → review+
Comment 9•8 years ago
|
||
mozreview-review |
Comment on attachment 8792907 [details]
Bug 1302062 - Remove RecordingsView from tests;
https://reviewboard.mozilla.org/r/79772/#review78800
This looks like it was a fun one, heh. LGTM
Attachment #8792907 -
Flags: review?(jsantell) → review+
Comment 10•8 years ago
|
||
mozreview-review |
Comment on attachment 8792908 [details]
Bug 1302062 - Rewrite browser_perf-console-record-08.js to be easier to understand;
https://reviewboard.mozilla.org/r/79774/#review78802
LGTM!!
::: devtools/client/performance/test/browser_perf-console-record-08.js:30
(Diff revision 2)
> +// Represents a recorded profile from console.profile().
> +const CONSOLE = 1;
> +// Represents a profile that is currently recording.
> +const RECORDING = 2;
> +// Represents a profile that is currently selected.
> +const SELECTED = 4;
Nice, much cleaner than before
Attachment #8792908 -
Flags: review?(jsantell) → review+
Assignee | ||
Comment 11•8 years ago
|
||
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8792907 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Attachment #8792908 -
Attachment is obsolete: true
Comment 13•8 years ago
|
||
Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c651f7174f37
Use React on performance recording list; r=jsantell
Comment 14•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•