58 bytes, text/x-review-board-request
Comment on attachment 8792906 [details] Bug 1302062 - Use React on performance recording list; https://reviewboard.mozilla.org/r/79770/#review78798 Looks good! Great comments in the RecordingsView too, w/r/t migration.
Attachment #8792906 - Flags: review?(jsantell) → review+
Comment on attachment 8792907 [details] Bug 1302062 - Remove RecordingsView from tests; https://reviewboard.mozilla.org/r/79772/#review78800 This looks like it was a fun one, heh. LGTM
Attachment #8792907 - Flags: review?(jsantell) → review+
Comment on attachment 8792908 [details] Bug 1302062 - Rewrite browser_perf-console-record-08.js to be easier to understand; https://reviewboard.mozilla.org/r/79774/#review78802 LGTM!! ::: devtools/client/performance/test/browser_perf-console-record-08.js:30 (Diff revision 2) > +// Represents a recorded profile from console.profile(). > +const CONSOLE = 1; > +// Represents a profile that is currently recording. > +const RECORDING = 2; > +// Represents a profile that is currently selected. > +const SELECTED = 4; Nice, much cleaner than before
Attachment #8792908 - Flags: review?(jsantell) → review+
Attachment #8792907 - Attachment is obsolete: true
Attachment #8792908 - Attachment is obsolete: true
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/c651f7174f37 Use React on performance recording list; r=jsantell
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.