If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Switch recording list to React component for perf tool

RESOLVED FIXED in Firefox 52

Status

()

Firefox
Developer Tools: Performance Tools (Profiler/Timeline)
P2
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: ntim, Assigned: gregtatum)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Updated

a year ago
Assignee: nobody → gtatum
(Assignee)

Updated

a year ago
Priority: -- → P2
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b89749a157b

Comment 8

a year ago
mozreview-review
Comment on attachment 8792906 [details]
Bug 1302062 - Use React on performance recording list;

https://reviewboard.mozilla.org/r/79770/#review78798

Looks good! Great comments in the RecordingsView too, w/r/t migration.
Attachment #8792906 - Flags: review?(jsantell) → review+

Comment 9

a year ago
mozreview-review
Comment on attachment 8792907 [details]
Bug 1302062 - Remove RecordingsView from tests;

https://reviewboard.mozilla.org/r/79772/#review78800

This looks like it was a fun one, heh. LGTM
Attachment #8792907 - Flags: review?(jsantell) → review+

Comment 10

a year ago
mozreview-review
Comment on attachment 8792908 [details]
Bug 1302062 - Rewrite browser_perf-console-record-08.js to be easier to understand;

https://reviewboard.mozilla.org/r/79774/#review78802

LGTM!!

::: devtools/client/performance/test/browser_perf-console-record-08.js:30
(Diff revision 2)
> +// Represents a recorded profile from console.profile().
> +const CONSOLE = 1;
> +// Represents a profile that is currently recording.
> +const RECORDING = 2;
> +// Represents a profile that is currently selected.
> +const SELECTED = 4;

Nice, much cleaner than before
Attachment #8792908 - Flags: review?(jsantell) → review+
https://treeherder.mozilla.org/#/jobs?repo=try&revision=98ca54094b1a
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8792907 - Attachment is obsolete: true
(Assignee)

Updated

a year ago
Attachment #8792908 - Attachment is obsolete: true

Comment 13

a year ago
Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c651f7174f37
Use React on performance recording list; r=jsantell

Comment 14

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c651f7174f37
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.