Switch recording list to React component for perf tool

RESOLVED FIXED in Firefox 52

Status

defect
P2
normal
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: ntim, Assigned: gregtatum)

Tracking

(Depends on 1 bug, Blocks 1 bug)

unspecified
Firefox 52
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Reporter

Description

3 years ago
No description provided.
Assignee

Updated

3 years ago
Assignee: nobody → gtatum
Assignee

Updated

3 years ago
Priority: -- → P2
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 8

3 years ago
mozreview-review
Comment on attachment 8792906 [details]
Bug 1302062 - Use React on performance recording list;

https://reviewboard.mozilla.org/r/79770/#review78798

Looks good! Great comments in the RecordingsView too, w/r/t migration.
Attachment #8792906 - Flags: review?(jsantell) → review+

Comment 9

3 years ago
mozreview-review
Comment on attachment 8792907 [details]
Bug 1302062 - Remove RecordingsView from tests;

https://reviewboard.mozilla.org/r/79772/#review78800

This looks like it was a fun one, heh. LGTM
Attachment #8792907 - Flags: review?(jsantell) → review+

Comment 10

3 years ago
mozreview-review
Comment on attachment 8792908 [details]
Bug 1302062 - Rewrite browser_perf-console-record-08.js to be easier to understand;

https://reviewboard.mozilla.org/r/79774/#review78802

LGTM!!

::: devtools/client/performance/test/browser_perf-console-record-08.js:30
(Diff revision 2)
> +// Represents a recorded profile from console.profile().
> +const CONSOLE = 1;
> +// Represents a profile that is currently recording.
> +const RECORDING = 2;
> +// Represents a profile that is currently selected.
> +const SELECTED = 4;

Nice, much cleaner than before
Attachment #8792908 - Flags: review?(jsantell) → review+
Comment hidden (mozreview-request)
Assignee

Updated

3 years ago
Attachment #8792907 - Attachment is obsolete: true
Assignee

Updated

3 years ago
Attachment #8792908 - Attachment is obsolete: true

Comment 13

3 years ago
Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c651f7174f37
Use React on performance recording list; r=jsantell

Comment 14

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c651f7174f37
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52

Updated

2 years ago
Depends on: 1425809
Depends on: 1466510

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.