1302093 - Move function bodies from InputData.h to InputData.cpp

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

InputData.h is used in a lot of places, and I often find myself doing long rebuilds because I touched something or the other in the method bodies. We should move those bodies to the .cpp file. I have a patch that does this and cleans up some formatting as well.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1302093 - Move all the method bodies from InputData.h to InputData.cpp to avoid rebuilding the world for itty-bitty changes.

Review commit: https://reviewboard.mozilla.org/r/78172/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78172/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

^ no functional changes. The diff for the .cpp might be a bit hard to read because I rearranged some of the functions so they're in the same order as in the .h file.

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8790266 [details]
Bug 1302093 - Move all the method bodies from InputData.h to InputData.cpp to avoid rebuilding the world for itty-bitty changes.

https://reviewboard.mozilla.org/r/78172/#review76640

Yeah, mozreview didn't do the best job of figuring out what happened in the cpp file, but this looks good.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7351b2e1dacc
Move all the method bodies from InputData.h to InputData.cpp to avoid rebuilding the world for itty-bitty changes. r=mstange

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7351b2e1dacc