Move function bodies from InputData.h to InputData.cpp

RESOLVED FIXED in Firefox 51

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

51 Branch
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

InputData.h is used in a lot of places, and I often find myself doing long rebuilds because I touched something or the other in the method bodies. We should move those bodies to the .cpp file. I have a patch that does this and cleans up some formatting as well.
Summary: Move function bodes from InputData.h to InputData.cpp → Move function bodies from InputData.h to InputData.cpp
^ no functional changes. The diff for the .cpp might be a bit hard to read because I rearranged some of the functions so they're in the same order as in the .h file.
Comment on attachment 8790266 [details]
Bug 1302093 - Move all the method bodies from InputData.h to InputData.cpp to avoid rebuilding the world for itty-bitty changes.

https://reviewboard.mozilla.org/r/78172/#review76640

Yeah, mozreview didn't do the best job of figuring out what happened in the cpp file, but this looks good.
Attachment #8790266 - Flags: review?(mstange) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7351b2e1dacc
Move all the method bodies from InputData.h to InputData.cpp to avoid rebuilding the world for itty-bitty changes. r=mstange
https://hg.mozilla.org/mozilla-central/rev/7351b2e1dacc
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.