1302101 - test failures: You need to have the reviewboard client extension installed in order to perform code reviews

Status: RESOLVED FIXED

(MozReview Graveyard :: Testing / Development Environment, defect)

Description

[:glob ✱]

using a clean rebuilt dev env, @6c8605c9e78f

$ ./run-tests --headless hgext/reviewboard/tests/test-push-http.t
[...]
@@ -196,6 +196,8 @@
   remote: adding file changes
   remote: added 1 changesets with 1 changes to 1 files
   remote: recorded push in pushlog
+  remote: REVIEWBOARD: You need to have the reviewboard client extension installed in order to perform code reviews.
+  remote: REVIEWBOARD: See https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hgext/reviewboard/README.rst

   $ hg -q up -r 1

@@ -228,6 +230,8 @@
   remote: adding file changes
   remote: added 1 changesets with 1 changes to 1 files (+1 heads)
   remote: recorded push in pushlog
+  remote: REVIEWBOARD: You need to have the reviewboard client extension installed in order to perform code reviews.
+  remote: REVIEWBOARD: See https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hgext/reviewboard/README.rst

 The Bugzilla user should have been recorded in the pushlog

@@ -282,6 +286,8 @@
   remote: adding file changes
   remote: added 1 changesets with 1 changes to 1 files
   remote: recorded push in pushlog
+  remote: REVIEWBOARD: You need to have the reviewboard client extension installed in order to perform code reviews.
+  remote: REVIEWBOARD: See https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hgext/reviewboard/README.rst

   $ http ${MERCURIAL_URL}test-repo/json-pushes --no-headers --body-file body
   200
@@ -339,6 +345,8 @@
   remote: adding file changes
   remote: added 2 changesets with 2 changes to 1 files
   remote: recorded push in pushlog
+  remote: REVIEWBOARD: You need to have the reviewboard client extension installed in order to perform code reviews.
+  remote: REVIEWBOARD: See https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hgext/reviewboard/README.rst
   submitting 2 changesets for review

   changeset:  4:9d326020e0dc

Comment 1

[:glob ✱]

Attachment: debug log

here's the full debug log.

at line 279 (search for 'cat .hg/.hgrc') you can see the reviewboard extension is present in the hgrc file (i can confirm that path is correct).
this precedes remote complaining about it being missing.

weirder things happen at about line 459 (search for 'SALT1473693384') ... the same error about the reviewboard extension not being installed, yet the push was successful.

Comment 2

[:glob ✱]

(In reply to Byron Jones ‹:glob› from comment #1)
> weirder things happen at about line 459 (search for 'SALT1473693384') ...

this should be (search for 'SALT1473693384 333')

Comment 3

[:glob ✱]

Attachment: reviewboard: Fix filtering of 'remote: REVIEWBOARD' responses (bug 1302101)

Bug 1298651 introduced a bug where it incorrectly expects a \n after the
"remote: REVIEWBOARD" string.

Review commit: https://reviewboard.mozilla.org/r/78220/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78220/

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8790336 [details]
reviewboard: Fix filtering of 'remote: REVIEWBOARD' responses (bug 1302101)

https://reviewboard.mozilla.org/r/78220/#review76728

``remote: %s\n`` is recorded in Mercurial's translation database for Mercurial 3.9. And so is ``remote: ``. ``remote: `` is also an i18n string for Mercurial 3.6. Not sure what's going on here. But this change should still work on Mercurial 3.6-3.9.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/1681d4352a27
reviewboard: Fix filtering of 'remote: REVIEWBOARD' responses r=gps