Closed Bug 1302128 Opened 3 years ago Closed 3 years ago

test_bug1277814.html appears to be defective

Categories

(Core :: Panning and Zooming, defect, P3)

48 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox48 --- wontfix
firefox49 --- wontfix
firefox50 --- wontfix
firefox51 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

I have some local patches for bug 1289432 which caused test_bug1277814 to start failing pretty consistently. Looking at the test I see a couple of issues with it:

1) what looks like a typo/oversight: moveMouseAndScrollWheelOver is async in that it queues up the mouse events, but the test continues without waiting for them to actually happen. i.e. it doesn't "yield" the return from that function, it just continues right through. If I change that to yield, then:

2) test hangs because the moveMouseAndScrollWheelOver waits for a scroll event to fire, but no such scroll event ever fires. It looks like this happens because the CSS transform change is animated, and the wheel event happens before the animation is done, so before either the APZ or the main thread knows that there is a scrollable subframe there.
Priority: -- → P3
Whiteboard: [gfx-noted]
Comment on attachment 8790303 [details]
Bug 1302128 - Fix a test so that it actually exercises the APZ layerization codepath it intends to exericse.

https://reviewboard.mozilla.org/r/78192/#review76710

Thanks for catching and fixing these issues!
Attachment #8790303 - Flags: review?(botond) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9679b6eb4bee
Fix a test so that it actually exercises the APZ layerization codepath it intends to exericse. r=botond
https://hg.mozilla.org/mozilla-central/rev/9679b6eb4bee
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.