Closed
Bug 1302160
Opened 8 years ago
Closed 8 years ago
Focus 1.1 master build doesn't work on any iOS version
Categories
(Focus-iOS :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
Iteration:
1.4
People
(Reporter: bnicholson, Assigned: bnicholson)
References
Details
(Whiteboard: [MobileAS])
With the Klar/Focus project merging that happened on the Focus repo, we never really had a chance to test those changes for bugs. One bug is that the ContentBlocker always throws an error at startup, meaning Focus doesn't work at all. This happens because of a subtle bug in ActionRequestHandler: AppInfo.ProductName is actually "ContentBlocker" rather than "Focus" or "Klar". That means we're looking for a file named "ContentBlocker-enabled-detector.json", which doesn't exist, so we fail.
|
Assignee | |
Comment 1•8 years ago
|
||
Fixed by always using a shared "enabled-detector.json" rather than having separate detectors for Focus/Klar. This means if any users have both Klar *and* Focus installed, having just one of them enabled will actually enable both. Not really a big problem, especially since no one will have both installed anyway. https://github.com/mozilla/focus/commit/5e22672bab98009e3b08d0206e7ad7533209c47c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•8 years ago
|
Priority: -- → P1
|
||
Updated•8 years ago
|
Iteration: --- → 1.4
You need to log in
before you can comment on or make changes to this bug.
Description
•