13022 - [feature]Wallet UE changes

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect, P3)

Description

[Stephen P. Morse]

A meeting was held yesterday to discuss the wallet/single-signon/cookie UE and
determine what changes we wanted to make to it.  The following action items came
out of that meeting and will be tracked by this bug report.

1. File bug report about "scroll=automatic" behaving like "scroll=yes" instead.
This causes an active vertical scroll bar to appear on the various viewers
alongside SELECT lists, even though their is enough vertical space for the list.

2. Revise the dialog that says "Do you want to save the username and password?"
so that it contains a "Never for this site" button as well as the already
existing "YES" and "NO" buttons.  Currently, pressing the "NO" button not only
doesn't save the current password being submitted, but also puts the site on a
list so that the dialog never again occurs for this site.  By adding the third
button, we can have the "NO" apply to this submission only without making it
permanent.

3. Adding a heading to the sigon viewer display to explain the list which
contains entries of the form <xxx>:<yyy>.  The heading will say SITE:USERNAME.
Although not mentioned at the meeting, this also applies to the cookie viewer
which also contains two entries separated by a colon.  In the case of the cookie
viewer, the heading will be SITE:COOKIE-NAME.

4. Use more meaningful names for schemas on the prefill dialog -- i.e., "last
name" instead of Name.Last.  It was agreed that this could be left as is since
there might be technical reasons that would make this change difficult.

5. Currently the prefill dialog shows a blank line as one of the choices for
each field that can be prefilled and the user selects the blank choice if he
doesn't want that field prefilled.  Instead of a blank line, the choice should
say "<don't prefill>".

6. Change the heading on the Wallet Editor that reads "Entries that mean the
same" to be "Entries that mean the same as the above".

7. Change the "Add New ..." buttons on the Wallet Editor to read simply "Add".

8. Place the "Add" buttons on the Wallet Editor so that they occur to the right
of the textfield rather than above them.

9. Grey out the "Add" buttons on the Wallet Editor if the corresponding text
field has no value in it.

10. On the original dialog for selecting a database key, add a second field so
that the user can confirm the value of the key.  Same for the dialog for
changing the key.  It was agreed that two back-to-back dialogs could be used
instead of a single dialog although the single dialog would be slightly
preferable.  (Note -- this is already covered in bug 7923 -- that bug will now
be closed out since it is a duplicate of this current report.)

11. Change the wording on the dialogs having to do with database password to use
the term "key" instead of "password".

12. Activate the following functions from a line that German will be adding at
the top of the chrome when a form is detected (this line will here-after be
referred to as the "German line"):

   Wallet Prefill
   Wallet Capture
   Change Database Key

13. Activate the following functions from an "about me" selection that will
appear on the task bar (if the "about me" does not materialize, then activate
them from the menu somewhere):

   Change Database Key (note that this appears on the German line as well)
   Present Interview Form
   Display Wallet Contents
   Display Logins
   Display Sites for no-preview formfill

Note that the last two items both bring up the same viewer (i.e., the single
signon viewer) but they differ in which tab is initially displayed when the
viewer comes up.

14. Activate the cookie viewer from the preference menu.

NOTE: Items 12, 13, and 14 will be done post beta (i.e., post M11).  The
remaining items will be attempted to be completed in time for M11.  So this bug
is being marked as M11 to cover items 1 through 11 only.  Items 12 through 14
will currently not be tracked (they may be so later).

Comment 1

[Stephen P. Morse]

*** Bug 10944 has been marked as a duplicate of this bug. ***

Comment 2

[Stephen P. Morse]

*** Bug 7923 has been marked as a duplicate of this bug. ***

Comment 3

[Stephen P. Morse]

1. Done.  Report filed is bug 13046.  In the process of coming up with a small
test case, I was able to figure out a work-around.  I checked in the work-around
so item 1 is no longer an issue here.

3. Done and checked in.
4. Will not do.
5. Done and checked in.
6. Done and checked in.
7. Done and checked in.
8. Done and checked in.

Items remaining to be done:

2, 9, 10, 11

Comment 4

[Stephen P. Morse]

11. Done

Items remaining to be done

2, 9, 10

Comment 5

[Matthew Tuck [:CodeMachine]]

For those interested, 2 is within the domain of bug #7380.

Comment 6

[Stephen P. Morse]

Implementation of item 2 is currently being blocked by bug 13228

Comment 7

[Stephen P. Morse]

item 10 done

items remaining to be done:

2 (blocked by bug 13228)
9 (awaiting details from German)

Comment 8

[Stephen P. Morse]

item 9: German now informs me that this can't be done from javascript yet
because of a blocking bug.  I'm awaiting the bug number from him.  Besides, this
particular item is of little importance.

So since I'm blocked by other bugs that won't be fixed until after beta, I have
to move this bug out post beta.  That means M14.

Comment 9

[kevinyen]

Steve -- great progress on these.  Way to go!

-kevin

Comment 10

[Stephen P. Morse]

Item 2 is now done as well.  Even though it was being blocked by 13228, the code
was restructured to use an ifdef which will be turned on as soon as 13228 is
fixed.  In the interim, two back-to-back dialogs will pop up.

Only outstanding item is #9.  German, I need to know the bug number that is
blocking this so I can add it as a dependency for this bug report.

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Disabling of widgets does indeed appear to work. See the "Advanced Edit" dialog
in the Editor, the "Find on this Page" dialog, etc. The "disabled" attribute of
the appropriate widget needs to be set to "true" to disable, and remove that
attribute to enable it again.

I am adding a re-work of the current Wallet Editor dialog to my List Of Things
To Do. I should be able to knock this one on the head for when post-beta
improvements can be made.

Comment 12

[Stephen P. Morse]

The only outstanding item in the original list is item 9 which is such a minor
item that I am going to forget about it.  But two other major items, namely 2
and 10, were never really handles satisfactorily because of lack of dialogs.

I just implemented a universal dialog from which I can custom-build various
dialogs.  The Yes,No,Never dialog requested in 2 and the double-password
dialog requested in 10 are special cases of the universal dialog.  So they are
now implemented.

Therefore closing this bug report out as fixed.  Will open a separate bug report
for items 12, 13, and 14.  That report is 23095.

Comment 13

[Paul MacQuiddy]

marking verified, any problems with the changes will get new bugs