1302224 - Raw log links broken

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The "open raw log" link on https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=34864667#L11783 doesn't work: it just opens up https://treeherder.mozilla.org/logviewer.html which then says there is no such job (because it wasn't handed a job id).

The DOM looks like this:

  <a title="Open the raw log in a new window" target="_blank" href="">
    stuff here
  </a>

Note the not-so-great href value.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

For some additional information for whoever looks at this:
When the log viewer page loads, there's a network request for https://treeherder.mozilla.org/api/project/mozilla-inbound/jobs/34864667/ and in the response, I see:
{
  logs: {
    0: {
      url: "https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-macosx64-debug/1472466570/mozilla-inbound_yosemite_r7-debug_test-mochitest-e10s-browser-chrome-7-bm135-tests1-macosx-build233.txt.gz"
    }
  }
}

Which IS the correct URL for the raw log, as shown in Treeherder's main UI for that job: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=6a5768dbae15533e940e98b650e2b9de449f19c3&selectedJob=34864667

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

The link's supposed to get parsed in here: https://github.com/mozilla/treeherder/blob/f0105d47f5cd72cbb8742025567c2ca17463f73e/ui/logviewer.html#L52

No clue why it isn't.

Comment 3

[William Lachance (:wlach)]

Fallout from bug 1258861, I'll fix. We no longer use the text log artifact here.

Comment 4

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1302224 > mozilla:master

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8790441 [details] [review]
[treeherder] wlach:1302224 > mozilla:master

Sorry, we should have caught this earlier. The fix is simple and has already been deployed to production as a hotfix.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8790441 [details] [review]
[treeherder] wlach:1302224 > mozilla:master

Looks like what I would do.

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/303007d9ad119fba8113b0660168ca3dad64a04b
Bug 1302224 - Fix link to raw log in logviewer (#1845)

Comment 8

[Boris Zbarsky [:bzbarsky]]

Is this deployed?  Because I'm still seeing the same broken behavior...

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm almost positive this was deployed to production, but I still see the broken behavior with the link from comment 0 (and more recent failures, if jobs needed to be ingested after this was deployed), too...

But if I run ./web-server.js locally with the tip of the master branch, it works for me.

Comment 10

[William Lachance (:wlach)]

Hmm, yes, still seems to reproducible. Weird, my fix work locally. Investigating...

Comment 11

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1302224-2 > mozilla:master

Comment 12

[William Lachance (:wlach)]

Comment on attachment 8791204 [details] [review]
[treeherder] wlach:1302224-2 > mozilla:master

There was a race between downloading the job information and rendering the template, because I added an "optimization" to not re-render the link on a digest cycle. In practice, the time taken to re-render the template is trivial.

Lesson learned: only use the "::" syntax where you really need it, and be careful about follow on effects.

I've applied the change as a hotfix to production, but I'll file this for review all the same. :)

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8791204 [details] [review]
[treeherder] wlach:1302224-2 > mozilla:master

rs=me

Comment 14

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2b65fa5ee474f7e90e86f972b463129032c96510
Bug 1302224 - Make sure raw log link in logviewer works (#1850)

We need to update the template value on angular digest cycles, because
we can't count on the "raw log url" being available when we first render the
template (the job may still be loading).

Comment 15

[William Lachance (:wlach)]

Hopefully this is really fixed now.