Closed Bug 1302286 Opened 3 years ago Closed 3 years ago

Remove `_getChildren` from the bookmarks engine

Categories

(Firefox :: Sync, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: lina, Assigned: lina)

References

Details

Attachments

(1 file, 1 obsolete file)

`_getChildren` can be replaced with a recursive query in `PlacesSyncUtils`, now that we've moved `getChangeRootIds` out of the tracker patch and into bug 1274496. This function is called `pullAllChanges` in the new tracker, but there's no reason we can't split it out and make the diff smaller.

This also removes a caller of `idForGUID`.
No longer blocks: 1295521
Depends on: 1295521
This would also drop _getNode and GUIDForId.
Assignee: nobody → kcambridge
Status: NEW → ASSIGNED
Priority: -- → P1
This can land ahead of bug 1295521, though it's a bit of a pain to keep the query in the bookmarks engine because of the special IDs conversion.
Attachment #8790902 - Attachment is obsolete: true
Attachment #8790902 - Flags: review?(markh)
Comment on attachment 8791016 [details]
Bug 1302286 - Remove `_getNode` and `_getChildren` from the bookmarks engine.

https://reviewboard.mozilla.org/r/78576/#review77178
Attachment #8791016 - Flags: review?(markh) → review+
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c2dca45dd21
Remove `_getNode` and `_getChildren` from the bookmarks engine. r=markh
https://hg.mozilla.org/mozilla-central/rev/7c2dca45dd21
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
No longer depends on: 1295521
You need to log in before you can comment on or make changes to this bug.