Closed Bug 1302286 Opened 5 years ago Closed 5 years ago
Children` from the bookmarks engine
58 bytes, text/x-review-board-request
`_getChildren` can be replaced with a recursive query in `PlacesSyncUtils`, now that we've moved `getChangeRootIds` out of the tracker patch and into bug 1274496. This function is called `pullAllChanges` in the new tracker, but there's no reason we can't split it out and make the diff smaller. This also removes a caller of `idForGUID`.
This would also drop _getNode and GUIDForId.
Assignee: nobody → kcambridge
Status: NEW → ASSIGNED
Priority: -- → P1
This can land ahead of bug 1295521, though it's a bit of a pain to keep the query in the bookmarks engine because of the special IDs conversion.
Comment on attachment 8791016 [details] Bug 1302286 - Remove `_getNode` and `_getChildren` from the bookmarks engine. https://reviewboard.mozilla.org/r/78576/#review77178
Attachment #8791016 - Flags: review?(markh) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/7c2dca45dd21 Remove `_getNode` and `_getChildren` from the bookmarks engine. r=markh
You need to log in before you can comment on or make changes to this bug.