|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
We should add a test to chek video UI when video has no audio. The test need to confirm that "noaudio" show up, in other hand, mute/unmute button and volume control are hidden.
temporarily hold from review for bug 1271765
Comment on attachment 8801023 [details] Bug 1302320 - add noaudio icon test for video control. https://reviewboard.mozilla.org/r/85832/#review84980 ::: toolkit/content/tests/widgets/mochitest.ini:7 (Diff revision 1) > skip-if = buildapp == 'mulet' || buildapp == 'b2g' > support-files = > audio.wav > audio.ogg > seek_with_sound.ogg > + video.ogg What's the size of the video file? Did you |git add| it? Can we reuse /mozilla-central/source/browser/base/content/test/general/video.ogg ?
The file is existed on repo alreay, I didn't do |git add| here. It looks like this file has never been used since 2008(first added).
Comment on attachment 8801023 [details] Bug 1302320 - add noaudio icon test for video control. https://reviewboard.mozilla.org/r/85832/#review94996
Attachment #8801023 - Flags: review?(jaws) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/84fee6da47a6 add noaudio icon test for video control. r=jaws
sorry had to backout for test_videocontrols_video_noaudio.html assertion failure, https://treeherder.mozilla.org/logviewer.html#?job_id=7078899&repo=autoland#L2408
Thank you Iris, I'll go fix it or maybe consider excluding this test from Android.
Backout by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/8ea8de32a32a Backed out changeset 84fee6da47a6 for test_videocontrols_video_noaudio.html assertion failure
Skipped this test on Android platform due to mobile video control doesn't care about `noaudio` state.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/4e27de747d61 add noaudio icon test for video control. r=jaws
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.