1302332 - Consider slowing down timers in x-domain iframes in background tabs

Status: NEW

(Core :: DOM: Core & HTML, defect, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: xdomain_bg_iframes_timer.diff

Adding something like
if (isBackgroundAndXDomain) {
  printf("xdomain background %s \n", currentBaseDomain.get());
}
after isBackgroundAndXDomain = !currentBaseDomain.Equals(topBaseDomain);
works as a log. And it is quite depressing. Tons of googlesyndication.com stuff, at least in the pages I tried.
higher value for dom.min_xdomain_background_timeout_value might make sense.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1acf918d53a

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

ok, I need to add some max(gMinXDomainBackgroundTimeoutValue, gMinBackgroundTimeoutValue), since on mobile gMinBackgroundTimeoutValue is really long.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2

https://treeherder.mozilla.org/#/jobs?repo=try&revision=68dfde5c5e84

Comment 4

[(no longer active)]

Olli, are you still working on this?

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Note, I believe we have a bug where we don't throttle background timers unless we hit conditions where we would have clamped to 4ms.  Andreas is working on it in bug 1316871.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

ah. No, I'm not working on this. Leftover from the qDOM work week before we had decided who works on what.

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Ehsan, my understanding is this issue is part of the qDom tab freezing task and P2 sounds the priority to me. Am I right?

Comment 8

[(no longer active)]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #7)
> Hi Ehsan, my understanding is this issue is part of the qDom tab freezing
> task

No, this was one of the ideas that we were brainstorming on.  At this point we're not considering treating iframes specially with regards to background tab freezing.

> and P2 sounds the priority to me. Am I right?

Sure! (To be honest I don't know what these priorities mean.  I've so far been ignoring them. :-)

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information