Closed Bug 1302348 Opened 4 years ago Closed 4 years ago

Report cubeb context init failures via telemetry

Categories

(Core :: Audio/Video: cubeb, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: kinetik, Assigned: kinetik)

Details

Attachments

(1 file)

With the landing of bug 1274479, we will no longer fall back to the WinMM backend permanently on Vista+ when there's no audio output available via WASAPI.

That should reduce the use of WinMM on Vista+ a bunch, and those cases will turn into a situation where cubeb_init fails but a subsequent cubeb_init might succeed (if some audio hardware was attached).

Bug 1300446 added a bunch of NULL tests when the cubeb context fails to initialize, but this had the side effect of changing the reporting of the stream init error telemetry slightly, at least for the MSG case where it relied on cubeb_stream_init to error on a NULL context.

We probably want to roll the result in with the existing AUDIOSTREAM_BACKEND_USED, probably as part of the first/other stream failure reports.
Report cubeb_init failures as if they're failures to init the first stream.
Attachment #8790585 - Flags: review?(padenot)
Rank: 15
Priority: -- → P1
Attachment #8790585 - Flags: review?(padenot) → review+
Pushed by mgregan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c046f354de8
Report cubeb context init failures via telemetry.  r=padenot
https://hg.mozilla.org/mozilla-central/rev/0c046f354de8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.