Closed Bug 1302358 Opened 8 years ago Closed 10 months ago

Use UTF-8 to encode error related strings.

Categories

(Core :: JavaScript Engine, defect, P3)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1490605
Tracking Flags:
Tracking Status
firefox51 --- affected

People

(Reporter: arai, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: triage-deferred) 

separated from bug 1289050.

Currently several functions that converts JSString* to const char* uses Latin1.
it should be better using UTF-8 instead, as there can be non-Latin1, and we're going to use UTF-8 for error reporting:
  * DecompileValueGenerator
  * ValueToSourceForError
  * CTypesToSourceForError
  * GetFunctionNameBytes
  * ValueToPrintable
  * AtomToPrintableString
  * maybe some more

maybe this should be done at the same time as changing filename encoding (bug 987069), as they can be in the same string.
Keywords: triage-deferred
Priority: -- → P3
Depends on: 1454207
Blocks: 1620583
Severity: normal → S3

fixed by bug 1490605 and bug 1485066

Status: NEW → RESOLVED
Closed: 10 months ago
Duplicate of bug: 1490605
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.