1302424 - Crash in java.lang.NullPointerException: at org.mozilla.gecko.home.CombinedHistoryAdapter$2$1.run(CombinedHistoryAdapter.java)

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-fbf0964e-f4be-4823-ad25-644362160913.
=============================================================


Seen while looking at Android Nightly Crash Stats: http://bit.ly/2cWDffl - right now #4 top browser crash. Not sure where to bucket this, but it probably doesn't belong in Core|Widget Android.

Comment 1

[:Grisha Kruglov]

Seems like a by-product of changes in Bug 1277978. We're invoking panelStateChangeListener before it is set.

Comment 2

[Jan Henning [:JanH]]

Ouch. I think that would also mean that in those instances the caching wouldn't really work, because without a panelStateChangeListener we can't retrieve the cached value, yet the RecentTabsAdapter has already initialised itself, because we're running the recentTabsUpdateHandler.
In any case yes, that line needs a null check.

Comment 3

[Jan Henning [:JanH]]

Attachment: Bug 1302424 - Check panelStateChangeListener isn't null before using it.

Review commit: https://reviewboard.mozilla.org/r/79270/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79270/

Comment 4

[Jan Henning [:JanH]]

Comment on attachment 8792006 [details]
Bug 1302424 - Check panelStateChangeListener isn't null before using it.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79270/diff/1-2/

Comment 5

[:Grisha Kruglov]

Comment on attachment 8792006 [details]
Bug 1302424 - Check panelStateChangeListener isn't null before using it.

https://reviewboard.mozilla.org/r/79270/#review77810

Let's get this crash to go away. JanH, does this warrant a follow up bug at all?

Comment 6

[Jan Henning [:JanH]]

Just an added null check, should be good without try.

Since I've managed to hit the top of the top-crashers list with this, it might not be a bad idea to get this on central as soon as possible, too.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bd98b397fb2
Check panelStateChangeListener isn't null before using it. r=Grisha

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1bd98b397fb2