Closed
Bug 1302424
Opened 5 years ago
Closed 5 years ago
Crash in java.lang.NullPointerException: at org.mozilla.gecko.home.CombinedHistoryAdapter$2$1.run(CombinedHistoryAdapter.java)
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
fennec | 51+ | --- |
firefox50 | --- | unaffected |
firefox51 | --- | fixed |
People
(Reporter: marcia, Assigned: JanH)
References
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
This bug was filed from the Socorro interface and is report bp-fbf0964e-f4be-4823-ad25-644362160913. ============================================================= Seen while looking at Android Nightly Crash Stats: http://bit.ly/2cWDffl - right now #4 top browser crash. Not sure where to bucket this, but it probably doesn't belong in Core|Widget Android.
Updated•5 years ago
|
tracking-fennec: --- → ?
Comment 1•5 years ago
|
||
Seems like a by-product of changes in Bug 1277978. We're invoking panelStateChangeListener before it is set.
Flags: needinfo?(jh+bugzilla)
Assignee | ||
Comment 2•5 years ago
|
||
Ouch. I think that would also mean that in those instances the caching wouldn't really work, because without a panelStateChangeListener we can't retrieve the cached value, yet the RecentTabsAdapter has already initialised itself, because we're running the recentTabsUpdateHandler. In any case yes, that line needs a null check.
Assignee: nobody → jh+bugzilla
Flags: needinfo?(jh+bugzilla)
Hardware: Unspecified → All
Comment hidden (mozreview-request) |
Updated•5 years ago
|
Attachment #8792006 -
Flags: review?(gkruglov)
Comment hidden (mozreview-request) |
Comment 5•5 years ago
|
||
mozreview-review |
Comment on attachment 8792006 [details] Bug 1302424 - Check panelStateChangeListener isn't null before using it. https://reviewboard.mozilla.org/r/79270/#review77810 Let's get this crash to go away. JanH, does this warrant a follow up bug at all?
Attachment #8792006 -
Flags: review?(gkruglov) → review+
Assignee | ||
Comment 6•5 years ago
|
||
Just an added null check, should be good without try. Since I've managed to hit the top of the top-crashers list with this, it might not be a bad idea to get this on central as soon as possible, too.
status-firefox50:
--- → unaffected
Keywords: checkin-needed
Pushed by gkruglov@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1bd98b397fb2 Check panelStateChangeListener isn't null before using it. r=Grisha
Keywords: checkin-needed
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1bd98b397fb2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
tracking-fennec: ? → 51+
You need to log in
before you can comment on or make changes to this bug.
Description
•