wasm 32-bit build failure: undefined reference to js::jit::MacroAssembler::wasmPatchBoundsCheck

RESOLVED FIXED in Firefox 51

Status

()

Core
JavaScript Engine: JIT
--
critical
RESOLVED FIXED
a year ago
9 months ago

People

(Reporter: decoder, Assigned: luke)

Tracking

({sec-want})

Trunk
mozilla51
x86
Linux
sec-want
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [fuzzblocker][adv-main51-])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
Our automation is hitting a build failure on 32-bit wasm shell builds:

    INPUT("../../modules/fdlibm/src/s_trunc.o")
    INPUT("../../modules/fdlibm/src/s_truncf.o")

../../build/unix/gold/ld: error: read-only segment has dynamic relocations
mozilla-inbound-clone-wasm/workspace/js/src/asmjs/WasmCode.cpp:120: error: undefined reference to 'js::jit::MacroAssembler::wasmPatchBoundsCheck(unsigned char*, unsigned int)'
mozilla-inbound-clone-wasm/workspace/js/src/vm/ArrayBufferObject.h:99: error: undefined reference to 'js::WasmArrayBufferMaxSize(js::ArrayBufferObjectMaybeShared const*)'
mozilla-inbound-clone-wasm/workspace/js/src/vm/ArrayBufferObject.h:99: error: undefined reference to 'js::WasmArrayBufferMaxSize(js::ArrayBufferObjectMaybeShared const*)'
mozilla-inbound-clone-wasm/workspace/js/src/vm/ArrayBufferObject.h:99: error: undefined reference to 'js::WasmArrayBufferMaxSize(js::ArrayBufferObjectMaybeShared const*)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
mozilla-inbound-clone-wasm/workspace/config/rules.mk:816: recipe for target 'libmozjs-51a1.so' failed
make[3]: *** [libmozjs-51a1.so] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory 'mozilla-inbound-build-wasm/workspace/arch/32/type/debug/js/src'
mozilla-inbound-clone-wasm/workspace/config/recurse.mk:71: recipe for target 'js/src/target' failed
make[2]: *** [js/src/target] Error 2
make[2]: Leaving directory 'mozilla-inbound-build-wasm/workspace/arch/32/type/debug'
mozilla-inbound-clone-wasm/workspace/config/recurse.mk:32: recipe for target 'compile' failed
make[1]: *** [compile] Error 2
make[1]: Leaving directory 'mozilla-inbound-build-wasm/workspace/arch/32/type/debug'
mozilla-inbound-clone-wasm/workspace/config/rules.mk:539: recipe for target 'default' failed
make: *** [default] Error 2


Luke, could you take a look since Benjamin can't look right now?
Flags: needinfo?(luke)
(Assignee)

Comment 1

a year ago
Created attachment 8790728 [details] [diff] [review]
fix-unified-bustage

Weird, the first one seems like it would've been caught by unified builds (or not have been a problem).  The second one is also confusing since WasmCode.cpp #includes ArrayBufferObject-inl.h.  Does this fix it?
Assignee: nobody → luke
Status: NEW → ASSIGNED
Flags: needinfo?(luke)
Attachment #8790728 - Flags: review?(bbouvier)
Attachment #8790728 - Flags: feedback?(choller)
Comment on attachment 8790728 [details] [diff] [review]
fix-unified-bustage

Review of attachment 8790728 [details] [diff] [review]:
-----------------------------------------------------------------

If that fixes decoder's bustage, let's go for it.
Attachment #8790728 - Flags: review?(bbouvier) → review+

Comment 3

a year ago
Pushed by lwagner@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/841360219550
Baldr: fix unified bustage (r=bbouvier)
(Assignee)

Comment 4

a year ago
Might as well land (since I think the changes are positive) and we can reopen if decoder still has problems.
(Reporter)

Comment 5

a year ago
Sorry, forgot to submit my response here. I confirmed that the patch works, got a successful build.

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/841360219550
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
(Reporter)

Updated

a year ago
Attachment #8790728 - Flags: feedback?(choller)
Whiteboard: fuzzblocker] → [fuzzblocker][adv-main51-]
You need to log in before you can comment on or make changes to this bug.