1302442 - [Static Analysis][Uninitialized scalar field] In Codegen.py

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that there are many uninitialised member variables in classes generated through Codegen.py. For example in SubleCryptoBinding.h:

>>struct RsaPssParams : public Algorithm
>>{
>>  uint32_t mSaltLength;
>>
>>  RsaPssParams();
>>
>>  explicit inline RsaPssParams(const FastDictionaryInitializer& )
>>    : Algorithm(FastDictionaryInitializer())
>>  {
>>    // Do nothing here; this is used by our "Fast" subclass
>>  }

We should eliminate from scanning these variables by modifying Codegen.py that for each member variable to add annotation: MOZ_INIT_OUTSIDE_CTOR

Comment 1

[Andi [:andi]]

Attachment: Bug 1302442 - Add ignore-initialization-check annotation to class member variables constructed by Codegen.

Review commit: https://reviewboard.mozilla.org/r/78430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78430/

Comment 2

[Andrea Marchesini [:baku]]

Or we can initialize them in the CTOR.

Comment 3

[Andi [:andi]]

(In reply to Andrea Marchesini [:baku] from comment #2)
> Or we can initialize them in the CTOR.
I think that's a little bit harder since we don't know the type of the variable only its literal type name.

Comment 4

[Peter Van der Beken [:peterv]]

Comment on attachment 8790749 [details]
Bug 1302442 - Add ignore-initialization-check annotation to class member variables constructed by Codegen.

https://reviewboard.mozilla.org/r/78430/#review78220

You need to change the ClassMember constructor to take a bool that signals whether to add this annotation. Prefixing the type makes the type member incorrect.

Comment 5

[Andi [:andi]]

Comment on attachment 8790749 [details]
Bug 1302442 - Add ignore-initialization-check annotation to class member variables constructed by Codegen.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/78430/diff/1-2/

Comment 6

[Peter Van der Beken [:peterv]]

Comment on attachment 8790749 [details]
Bug 1302442 - Add ignore-initialization-check annotation to class member variables constructed by Codegen.

https://reviewboard.mozilla.org/r/78430/#review79238

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d28809f3b445
Add ignore-initialization-check annotation to class member variables constructed by Codegen. r=peterv

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d28809f3b445

Comment 9

[Gerry Chang [:gchang]]

Mark 51 as fix-optional. If it's worth uplifting to 51, feel free to nominate it.