Closed
Bug 1302468
Opened 8 years ago
Closed 7 years ago
Firefox Beta reports channel as 'release' when build is RC due to use of Services.appinfo.defaultUpdateChannel
Categories
(Firefox :: Tours, defect, P3)
Tracking
()
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: agibson, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
I'm not sure if this is a bug or should be considered intentional behavior, but I'm filing here just to find out. STR: 1.) Download Firefox Beta release candidate (I downloaded b10 from https://www.mozilla.org/en-US/firefox/channel/ and updated manually to RC). 2.) Visit: https://www.mozilla.org/en-US/firefox/private-browsing/ 3.) Open the Web Console and paste the following: Mozilla.UITour.getConfiguration('appinfo', function (config) { console.dir(config); }); Expected results: The value for `defaultUpdateChannel` should be `beta`. Actual results: Note the value for `defaultUpdateChannel` is `release`. I understand that RC should be as close to the final release as possible, which is probably why this occurs. But it would be useful for us to find out how much we can rely on this information on mozorg, if this is in fact intentional behavior. Thanks
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(MattN+bmo)
Assignee | ||
Comment 1•8 years ago
|
||
This is because nsAppRunner actually compiles in "release" as MOZ_UPDATE_CHANNEL for the rc builds over in http://searchfox.org/mozilla-central/rev/bcc9ea6947878ca6378e5b7d6f08c1c090ed9eb7/toolkit/xre/nsAppRunner.cpp#1001-1006 . We just forward that info in http://searchfox.org/mozilla-central/rev/bcc9ea6947878ca6378e5b7d6f08c1c090ed9eb7/browser/components/uitour/UITour.jsm#1805-1807 So I would say "intentional", but maybe Matt feels differently...
Comment 2•8 years ago
|
||
(In reply to Alex Gibson [:agibson] from comment #0) > I understand that RC should be as close to the final release as possible, > which is probably why this occurs. But it would be useful for us to find out > how much we can rely on this information on mozorg, if this is in fact > intentional behavior. Lizard could probably explain what's going on better. I'm surprised that the channel would be "release" for an RC build served to users on the "beta" channel.
Flags: needinfo?(MattN+bmo) → needinfo?(lhenry)
Comment 3•8 years ago
|
||
The update channel should still be beta, from the channel-prefs.js file: "pref("app.update.channel", "beta");" Can you see and use that info for your purposes? Is it that you want to measure who is visiting mozilla.org, or that you would like users to see that they are on the beta channel, or something else? Anyway, yes, we build the RC from the mozilla-release branch, so the branding, other info, build options, etc. will match what they should be upon moving to the release channel.
Flags: needinfo?(lhenry)
Reporter | ||
Comment 4•8 years ago
|
||
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #3) > The update channel should still be beta, from the channel-prefs.js file: > "pref("app.update.channel", "beta");" Can you see and use that info for > your purposes? Is it that you want to measure who is visiting mozilla.org, > or that you would like users to see that they are on the beta channel, or > something else? > > Anyway, yes, we build the RC from the mozilla-release branch, so the > branding, other info, build options, etc. will match what they should be > upon moving to the release channel. We have an upcoming request to display the appropriate channel a user is on when they visit the main Firefox download page, but we noticed this behavior when testing out in Beta. We only have access to what information UITour provides us with here. This is a bit of an edge case scenario, but it does mean there could be times when the page would tell Beta users they are on the Release channel, which isn't ideal. This isn't a deal-breaker on our side I think, it was more of a request to see what's possible. If this is intended behavior, then we can make the limitation clear to others. Thanks for the info.
Comment 5•8 years ago
|
||
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #3) > The update channel should still be beta, from the channel-prefs.js file: > "pref("app.update.channel", "beta");" What should MOZ_UPDATE_CHANNEL be for RC though?
Flags: needinfo?(lhenry)
Comment 6•8 years ago
|
||
Yes, I think so. We build the RC to be exactly what it is going to be when it's put onto the release channel. That does mean that some users, while on RC in the last week of the beta cycle, might go to download.mozilla.org and would see that they are already up to date. They could still see from "About Firefox" or about:support that they are really on the beta channel.
Flags: needinfo?(lhenry)
Comment 8•7 years ago
|
||
UITour.getConfiguration("appinfo") should use UpdateUtils.getUpdateChannel for 'defaultUpdateChannel'
Blocks: 1402866
Priority: -- → P3
Summary: Firefox Beta reports channel as 'release' when build is RC. → Firefox Beta reports channel as 'release' when build is RC due to use of Services.appinfo.defaultUpdateChannel
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8928180 [details] Bug 1302468 - use UpdateUtils to determine the update channel for UITour, https://reviewboard.mozilla.org/r/199408/#review204524 Thanks!
Attachment #8928180 -
Flags: review?(MattN+bmo) → review+
Comment 12•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s d56a8c7f330b -d 597624409f4c: rebasing 433891:d56a8c7f330b "Bug 1302468 - use UpdateUtils to determine the update channel for UITour, r=MattN" (tip) merging browser/components/uitour/UITour.jsm warning: conflicts while merging browser/components/uitour/UITour.jsm! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request) |
Comment 14•7 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/6879d23d39e8 use UpdateUtils to determine the update channel for UITour, r=MattN
Comment 15•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6879d23d39e8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in
before you can comment on or make changes to this bug.
Description
•