Closed Bug 1302493 Opened 4 years ago Closed 4 years ago

Update AsyncPanZoom.md

Categories

(Core :: Panning and Zooming, defect, P3)

51 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
e10s ? ---
firefox51 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Since gfx/doc/AsyncPanZoom.md was last touched, a number of changes have landed in the code (see dependent bugs). The doc needs updating.
Comment on attachment 8790858 [details]
Bug 1302493 - Update the in-tree APZ documentation to reflect various changes since it was last updated.

https://reviewboard.mozilla.org/r/78474/#review77114

::: gfx/doc/AsyncPanZoom.md:189
(Diff revision 1)
>  Input events arrive from the hardware/widget code into the APZ via APZCTreeManager::ReceiveInputEvent.
>  The thread that invokes this is called the input thread, and may or may not be the same as the Gecko main thread.
>  </li>
>  <li value="2">
> -Conceptually the first thing that the APZCTreeManager does is to group these events into "input blocks".
> -An input block is a contiguous set of events that get handled together.
> +Conceptually the first thing that the APZCTreeManager does is to associate these events with "input blocks".
> +An input block is a set of events that share certain properties.

Perhaps mention that they are intended to represent a single gesture?

::: gfx/doc/AsyncPanZoom.md:269
(Diff revision 1)
>  
>  #### Threading considerations
>  
>  The bulk of the input processing in the APZ code happens on what we call "the input thread".
>  In practice the input thread could be the Gecko main thread, the compositor thread, or some other thread.
>  There are obvious downsides to using the Gecko main thread - that is, "asynchronous" panning and zooming is not really asynchronous as input events can only be processed while Gecko is idle.

Probably worth mentioning e10s here. That is, if input handling happens on the main thread of the parent process, it's only the parent process instance of Gecko that needs to be idle, not the more interesting content process instance.
Attachment #8790858 - Flags: review?(botond) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fae43b8da4a2
Update the in-tree APZ documentation to reflect various changes since it was last updated. r=botond
https://hg.mozilla.org/mozilla-central/rev/fae43b8da4a2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.