1302516 - Make ZipCollection thread-safe

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Eugen Sawin [:esawin]]

Moving patch 3 out of bug 1302189.

Comment 1

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1302516-1.2-Add-mutex-locking-to-ZipCollection-z.patch

Addressed comments from https://bugzilla.mozilla.org/show_bug.cgi?id=1302189#c6.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bfde65d691a
[1.2] Add mutex locking to ZipCollection zip vector access. r=glandium

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5bfde65d691a

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

We should probably uplift this (and maybe other linker fixes?)

Comment 5

[Eugen Sawin [:esawin]]

Comment on attachment 8790903 [details] [diff] [review]
0001-Bug-1302516-1.2-Add-mutex-locking-to-ZipCollection-z.patch

Approval Request Comment
[Feature/regressing bug #]: None
[User impact if declined]: Intermittent crashes on startup
[Describe test coverage new/current, TreeHerder]: Nightly only
[Risks and why]: Minimal, it just adds a mutex around container access
[String/UUID change made/needed]: None

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8790903 [details] [diff] [review]
0001-Bug-1302516-1.2-Add-mutex-locking-to-ZipCollection-z.patch

Crash fix, Beta50+ 

(already on Aurora51)

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2c9b14f46945