Closed Bug 1302516 Opened 8 years ago Closed 8 years ago

Make ZipCollection thread-safe

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
51 Branch
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox50 fixed, firefox51 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 51
Tracking Flags:
Tracking Status
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: esawin, Assigned: esawin)

References

Details

Attachments

(1 file)

0001-Bug-1302516-1.2-Add-mutex-locking-to-ZipCollection-z.patch
3.41 KB, patch
esawin
: review+
ritu
: approval-mozilla-beta+
Details | Diff | Splinter Review 
Moving patch 3 out of bug 1302189.
Addressed comments from https://bugzilla.mozilla.org/show_bug.cgi?id=1302189#c6.
Attachment #8790903 - Flags: review+
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bfde65d691a
[1.2] Add mutex locking to ZipCollection zip vector access. r=glandium
https://hg.mozilla.org/mozilla-central/rev/5bfde65d691a
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
We should probably uplift this (and maybe other linker fixes?)
Flags: needinfo?(esawin)
Comment on attachment 8790903 [details] [diff] [review]
0001-Bug-1302516-1.2-Add-mutex-locking-to-ZipCollection-z.patch

Approval Request Comment
[Feature/regressing bug #]: None
[User impact if declined]: Intermittent crashes on startup
[Describe test coverage new/current, TreeHerder]: Nightly only
[Risks and why]: Minimal, it just adds a mutex around container access
[String/UUID change made/needed]: None
Flags: needinfo?(esawin)
Attachment #8790903 - Flags: approval-mozilla-beta?
Attachment #8790903 - Flags: approval-mozilla-aurora?
Comment on attachment 8790903 [details] [diff] [review]
0001-Bug-1302516-1.2-Add-mutex-locking-to-ZipCollection-z.patch

Crash fix, Beta50+ 

(already on Aurora51)
Attachment #8790903 - Flags: approval-mozilla-beta?
Attachment #8790903 - Flags: approval-mozilla-beta+
Attachment #8790903 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/releases/mozilla-beta/rev/2c9b14f46945
status-firefox50: affected → fixed
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: