CTCP messages all get the same content

RESOLVED FIXED in Instantbird 52

Status

Chat Core
IRC
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: freaktechnik, Assigned: freaktechnik)

Tracking

trunk
Instantbird 52

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Currently all extracted CTCP messages passed to handlers will be exactly the same, if there are multiple.

The problem is that https://dxr.mozilla.org/comm-central/source/chat/protocols/irc/ircCTCP.jsm#24 does not clone the aMessage and instead just writes the properties on it, which then the next iteration will override, which means there will just be an array filled with the same object.
(Assignee)

Updated

2 years ago
Assignee: nobody → martin
Status: NEW → ASSIGNED
(Assignee)

Comment 1

2 years ago
Created attachment 8790931 [details] [diff] [review]
bug1302538.patch

I'm not sure where tests for this would go, as there are four CTCP test files, I'm also not fluent enough in CTCP to know what a CTCP message would look like that would trigger this bug.
Attachment #8790931 - Flags: review?(clokep)
Attachment #8790931 - Flags: review?(clokep) → review+
https://hg.mozilla.org/comm-central/rev/2938c87195de

Thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 52
You need to log in before you can comment on or make changes to this bug.