Closed Bug 1302538 Opened 5 years ago Closed 5 years ago

CTCP messages all get the same content

Categories

(Chat Core :: IRC, defect)

Product:
Chat Core
Component:
IRC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Instantbird 52

People

(Reporter: freaktechnik, Assigned: freaktechnik)

Details

Attachments

(1 file)

bug1302538.patch
1.22 KB, patch
clokep
: review+
Details | Diff | Splinter Review 
Currently all extracted CTCP messages passed to handlers will be exactly the same, if there are multiple.

The problem is that https://dxr.mozilla.org/comm-central/source/chat/protocols/irc/ircCTCP.jsm#24 does not clone the aMessage and instead just writes the properties on it, which then the next iteration will override, which means there will just be an array filled with the same object.
Assignee: nobody → martin
Status: NEW → ASSIGNED
Attached patch bug1302538.patch — — Splinter Review 
I'm not sure where tests for this would go, as there are four CTCP test files, I'm also not fluent enough in CTCP to know what a CTCP message would look like that would trigger this bug.
Attachment #8790931 - Flags: review?(clokep)
Attachment #8790931 - Flags: review?(clokep) → review+
https://hg.mozilla.org/comm-central/rev/2938c87195de

Thanks!
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 52
You need to log in before you can comment on or make changes to this bug.