1302729 - Media control notification is not displayed when HLS video is playing

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Audio/Video, defect, P3)

Description

[Sorina Florean [:sflorean]]

Environment: 
Device: Nexus 5 (Android 6.0.1);
Build: Nightly 51.0a1 (2016-09-13);

Steps to reproduce:
1. 
2. 
3. 

Expected result:


Actual result:

Notes:

Comment 1

[Alastor Wu [:alwu]]

I don't think this is a issue because HLS is playing by external player, not gecko.
I would suggest to mark this bug as wontfix.

Comment 2

[Blake Wu [:bwu][:blakewu]]

Users might not be aware of that or can tell that difference, and they might think media control should be able to control all the playback triggered by Fennec.

Comment 3

[Alastor Wu [:alwu]]

It's huge difference between using external player(android view) and gecko media playback. Eg. We can't play video in background when using former one. So I don't think we need add media control for this case.

Comment 4

[Blake Wu [:bwu][:blakewu]]

I got your point. HLS playback cannot be played in the background, which is not consistent with other playback on Fennec. 
Anyway, the biggest values of media control is to let user know there is media playing in the background and they can easily pause/resume it. So this bug is not so serious since HLS playback is always in the foreground. I am going to set this bug as P3. But for consistence, IMHO it would be better to show notification for all the media playback. Maybe there is a way to let HLS videoview notify/trigger media control UI.

Comment 5

[Rachelle Yang [:ryang][[e-mail]]]

Dear Sorina, because this HLS video is not "actually" handled by Fennec.
we would suppose the media notification enhancement works for the media played and processed by Fennec.
Please kindly share your view on this.
If you are fine with this, I would change status to WONTFIX.
Thank you very much !!

Comment 6

[Blake Wu [:bwu][:blakewu]]

I have different opinion on this. For consistency, it would be better to show media control notification. User cannot tell the difference I think. Maybe we should ask UX's opinion as well.

Comment 7

[Sorina Florean [:sflorean]]

(In reply to Rachelle Yang [:ryang][[e-mail]] from comment #5)
> Dear Sorina, because this HLS video is not "actually" handled by Fennec.
> we would suppose the media notification enhancement works for the media
> played and processed by Fennec.
> Please kindly share your view on this.
> If you are fine with this, I would change status to WONTFIX.
> Thank you very much !!

Hi Rachelle, 
I think that will be useful for users to show them media control notification when Fennec is playing HLS video, if there is a way to do that.
Thanks!

Comment 8

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Blake Wu [:bwu][:blakewu] from comment #6)
> I have different opinion on this. For consistency, it would be better to
> show media control notification. User cannot tell the difference I think.
> Maybe we should ask UX's opinion as well.

thanks for looping me in here Blake!

I'd agree with what Blake has said so far about consistency. This is not necessarily something that the user recognizes (what is HLS, what is not) and so we should be more obvious in our UX approach. 

It might be that we find we don't need this later on down the line, but for consistency of experience, I think we should show the media control notification for HLS videos too.

Comment 9

[Rachelle Yang [:ryang][[e-mail]]]

Thank you , Anthony.

Hello Blake, based on the comments above and the discussion, 
May I ask for your help to make progress on the HLS-video related scenarios and also  how to proceed with  this bug Bug 1302729 ?

Thank you very much !

Comment 10

[Blake Wu [:bwu][:blakewu]]

This is a P3 bug which is not so important compared to other bugs in media control. IMO, this should not block media control landing in 52. Ni Sebastian to see if he has other concerns on this.
So let's focus on P1/P2 bugs first.

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

I agree. Technically those are two separate things. Let's first try to fix all use cases when Gecko is playing media. Then let's see if we can get it working for HLS too (because users do not know the difference). This will require some investigation and is a bigger task.

Whether we should ship the media control notification without support for HLS or not is something product/barbara should decide. I'm in favor of shipping this early.

Comment 12

[Barbara Bermes [:barbara] - NI please!]

I agree with Sebastian. First get all the bugs related to Gecko playing media fixed.

Also support for HLS should not block the release of media controls.

Comment 13

[Sorina Florean [:sflorean]]

With new implementation, media control is displayed for HLS video. Closing this as WORKSFORME.